Skip to content

Revive UI tests - #466

Merged
tomholub merged 7 commits into
masterfrom
feature/ui-tests-revive
Sep 2, 2021
Merged

Revive UI tests#466
tomholub merged 7 commits into
masterfrom
feature/ui-tests-revive

Conversation

@Kharchevskyi

@Kharchevskyi Kharchevskyi commented Aug 26, 2021

Copy link
Copy Markdown
Contributor

This PR revive imap smtp ui tests

  • Login with user without key backups and emails
  • Login and cancel login flow
  • Add ui test to verify after app restart
  • Add ui test for login with bad pass phrase

close #471
close #465
issue #439 // tom


Tests:

  • Added UI Tests

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@Kharchevskyi Kharchevskyi left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kharchevskyi
Kharchevskyi marked this pull request as ready for review August 30, 2021 14:40
@Kharchevskyi
Kharchevskyi requested a review from tomholub August 30, 2021 14:49
Comment thread FlowCrypt/Functionality/Mail Provider/Backup Provider/Imap+Backup.swift Outdated
Comment thread FlowCryptUITests/SignInImapTest.swift Outdated
Comment thread FlowCryptUITests/SignInImapTest.swift Outdated
Comment thread FlowCryptUITests/SignInImapTest.swift Outdated
Comment thread FlowCryptUITests/SignInImapTest.swift Outdated
Comment thread FlowCryptUITests/SignInImapTest.swift
Comment thread FlowCryptUITests/SignInImapTest.swift
Comment thread FlowCryptUITests/SignInImapTest.swift
@tomholub

Copy link
Copy Markdown
Collaborator

It doesn't seem this closes #439 yet - can you confirm? There are still tests left commented - the ones that edit state on IMAP.

@Kharchevskyi

Copy link
Copy Markdown
Contributor Author

I reenabled only tests which doesn't change state on Imap server.

@tomholub

Copy link
Copy Markdown
Collaborator

I reenabled only tests which doesn't change state on Imap server.

Good - please update the PR description so that it doesn't close #439 since there will be more tests to re-enable later, once we figure out how to run them without messing up the IMAP server data.

@Kharchevskyi

Copy link
Copy Markdown
Contributor Author

This is just a mention, it will not close the issue. Removed to be 100% sure

@tomholub

tomholub commented Sep 2, 2021

Copy link
Copy Markdown
Collaborator

I must have overlooked earlier. I just put the mention back.

@tomholub
tomholub merged commit 58afbd7 into master Sep 2, 2021
@tomholub
tomholub deleted the feature/ui-tests-revive branch September 2, 2021 15:09
@Kharchevskyi Kharchevskyi mentioned this pull request Sep 4, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rename att to attachment Wrong error message in case there are no emails on account

2 participants