Skip to content

fix(selfhost): docker-compose.miner.yml still tags the fleet image gittensory-miner:latest #5935

Description

@JSONbored

Context

packages/loopover-miner/docker-compose.miner.yml (the AMS fleet-mode compose file, #5177) still carries
the pre-rename image tag and entrypoint comment:

services:
  miner:
    build:
      context: ../..
      dockerfile: packages/loopover-miner/Dockerfile
    image: gittensory-miner:latest
    # ENTRYPOINT is `gittensory-miner`; `run` is the continuous fleet-worker loop.
    command: ["run"]

The Dockerfile it builds from sets the real, current entrypoint:

# packages/loopover-miner/Dockerfile
ENTRYPOINT ["loopover-miner"]

and packages/loopover-miner/DEPLOYMENT.md consistently refers to the built image as loopover-miner:latest
throughout its fleet-mode walkthrough (build/push examples, Kubernetes section). This one compose file's
image: tag and comment are the only place in the fleet-mode toolchain still saying gittensory-miner.

Practical effect: this isn't a crash — Compose happily tags a locally-built image whatever the image:
key says — but it's a real, confusing inconsistency for any operator who builds via this file
(docker compose -f docker-compose.miner.yml up -d --build) and then tries to reference the resulting image
by the name every other doc in the package uses (loopover-miner:latest, e.g. from k8s/miner-deployment.yaml's
own build instructions or docs/sizing.md). docker images shows gittensory-miner:latest, not
loopover-miner:latest, breaking that cross-reference silently.

Requirements

  • Change image: gittensory-miner:latest to image: loopover-miner:latest.
  • Update the stale # ENTRYPOINT is \gittensory-miner`comment to sayloopover-miner, matching the Dockerfile's real ENTRYPOINT`.
  • No functional/build-behavior change beyond the tag string and comment text — the build: block (context,
    dockerfile path) is already correct and untouched.

Deliverables

  • packages/loopover-miner/docker-compose.miner.yml: image: tag updated to loopover-miner:latest.
  • Same file: entrypoint comment updated to reference loopover-miner.
  • Extend the existing test/unit/miner-docker-compose.test.ts (which already parses this file with
    yaml.parse and asserts on compose.services.miner) with an assertion that miner.image is
    loopover-miner:latest, so this can't regress silently again.

Test Coverage Requirements

test/unit/miner-docker-compose.test.ts is a real Vitest suite (not Codecov-gated, since the target file is
packages/** YAML, not src/**) — extend it rather than adding a new file. The new assertion must fail
against the current (buggy) gittensory-miner:latest value to prove it actually catches the regression before
the fix lands.

Expected Outcome

docker compose -f packages/loopover-miner/docker-compose.miner.yml up -d --build produces an image tagged
loopover-miner:latest, matching the name used consistently everywhere else in DEPLOYMENT.md, k8s/, and
docs/sizing.md.

Links & Resources

Metadata

Metadata

Assignees

No one assigned

    Labels

    gittensor:bugGittensor-scored bug fix — scores a 0.05x multiplier.help wantedExtra attention is needed

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions