Skip to content

fix(selfhost): tag the fleet compose image loopover-miner:latest - #6013

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
davion-knight:fix-selfhost-miner-compose-image-tag
Jul 15, 2026
Merged

fix(selfhost): tag the fleet compose image loopover-miner:latest#6013
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
davion-knight:fix-selfhost-miner-compose-image-tag

Conversation

@davion-knight

Copy link
Copy Markdown
Contributor

Closes #5935.

packages/loopover-miner/docker-compose.miner.yml still tagged the built image gittensory-miner:latest (and referenced the old name in its header/entrypoint comments), while the Dockerfile's real ENTRYPOINT is loopover-miner and every other fleet-mode doc (DEPLOYMENT.md, k8s/miner-deployment.yaml) uses loopover-miner:latest. An operator who builds via this file then sees gittensory-miner:latest in docker images, silently breaking those cross-references.

Changes

  • docker-compose.miner.yml: image:loopover-miner:latest; entrypoint comment → loopover-miner; and the file-header comment refreshed to the current name for consistency (no functional/tag residue left).
  • test/unit/miner-docker-compose.test.ts: extended the existing suite (per the issue) with an assertion that miner.image is loopover-miner:latest.

Validation

  • Full suite passes (6/6).
  • Proved the new assertion catches the regression: temporarily reverting the tag to gittensory-miner:latest makes exactly that test fail, then passes again once restored — as the issue's Test Coverage Requirements ask.
  • packages/** YAML + test/**, both outside Codecov's coverage.include, so no patch-coverage gate applies.

packages/loopover-miner/docker-compose.miner.yml still tagged the built
image gittensory-miner:latest (and its entrypoint/header comments used the
old name), while the Dockerfile ENTRYPOINT and every other fleet-mode doc
(DEPLOYMENT.md, k8s/miner-deployment.yaml) use loopover-miner:latest -- so
docker images cross-references from those docs resolved to the wrong name.
Update the image tag and the stale name comments, and extend the existing
miner-docker-compose test with an image-tag regression assertion.

Closes JSONbored#5935
@davion-knight
davion-knight requested a review from JSONbored as a code owner July 15, 2026 06:49
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.15%. Comparing base (ad103f0) to head (ea3c4d1).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6013   +/-   ##
=======================================
  Coverage   95.15%   95.15%           
=======================================
  Files         589      589           
  Lines       46826    46826           
  Branches    14958    14958           
=======================================
  Hits        44559    44559           
  Misses       1511     1511           
  Partials      756      756           
Flag Coverage Δ
shard-1 43.89% <ø> (-0.01%) ⬇️
shard-2 36.45% <ø> (+0.01%) ⬆️
shard-3 31.94% <ø> (-0.20%) ⬇️
shard-4 32.01% <ø> (+0.76%) ⬆️
shard-5 32.24% <ø> (-0.33%) ⬇️
shard-6 44.91% <ø> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 15, 2026
@loopover-orb

loopover-orb Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-15 07:05:00 UTC

2 files · 1 AI reviewer · no blockers · readiness 77/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a small, correct fix that renames the Docker image tag from the stale gittensory-miner:latest to loopover-miner:latest in the compose file, matching the Dockerfile's actual ENTRYPOINT and other fleet-mode docs. The accompanying test change adds a direct assertion on the image tag, and the PR description credibly demonstrates the test catches the regression by reverting and re-applying the fix. The change is narrow, well-scoped, and closes a linked issue (#5935).

Nits — 2 non-blocking
  • The comment in miner-docker-compose.test.ts:28-30 is a bit verbose for a single assertion, though it does add useful context linking to the issue and cross-referenced docs.
  • Consider a quick grep across the repo for any remaining 'gittensory-miner' references (e.g., README snippets, CI scripts) to ensure this rename is fully complete, since the PR description only mentions DEPLOYMENT.md and k8s/miner-deployment.yaml as already correct.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #5935
Related work ⚠️ 2 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 143 registered-repo PR(s), 95 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor davion-knight; Gittensor profile; 143 PR(s), 0 issue(s).
Gate result ✅ Passing No configured blocker found.
Improvement ℹ️ Insufficient signal risk: clean · value: insufficient-signal · LLM: minor
Linked issue satisfaction

Addressed
The diff changes image: gittensory-miner:latest to loopover-miner:latest, updates the entrypoint comment to reference loopover-miner, and extends the test file with an assertion on miner.image matching the required value.

Review context
Contributor next steps
  • Start here: Review top overlaps.
  • Then work through the remaining 3 steps in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 13afd8f into JSONbored:main Jul 15, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(selfhost): docker-compose.miner.yml still tags the fleet image gittensory-miner:latest

1 participant