fix(selfhost): tag the fleet compose image loopover-miner:latest - #6013
Conversation
packages/loopover-miner/docker-compose.miner.yml still tagged the built image gittensory-miner:latest (and its entrypoint/header comments used the old name), while the Dockerfile ENTRYPOINT and every other fleet-mode doc (DEPLOYMENT.md, k8s/miner-deployment.yaml) use loopover-miner:latest -- so docker images cross-references from those docs resolved to the wrong name. Update the image tag and the stale name comments, and extend the existing miner-docker-compose test with an image-tag regression assertion. Closes JSONbored#5935
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6013 +/- ##
=======================================
Coverage 95.15% 95.15%
=======================================
Files 589 589
Lines 46826 46826
Branches 14958 14958
=======================================
Hits 44559 44559
Misses 1511 1511
Partials 756 756
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-15 07:05:00 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 2 non-blocking
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Closes #5935.
packages/loopover-miner/docker-compose.miner.ymlstill tagged the built imagegittensory-miner:latest(and referenced the old name in its header/entrypoint comments), while theDockerfile's realENTRYPOINTisloopover-minerand every other fleet-mode doc (DEPLOYMENT.md,k8s/miner-deployment.yaml) usesloopover-miner:latest. An operator who builds via this file then seesgittensory-miner:latestindocker images, silently breaking those cross-references.Changes
docker-compose.miner.yml:image:→loopover-miner:latest; entrypoint comment →loopover-miner; and the file-header comment refreshed to the current name for consistency (no functional/tag residue left).test/unit/miner-docker-compose.test.ts: extended the existing suite (per the issue) with an assertion thatminer.imageisloopover-miner:latest.Validation
gittensory-miner:latestmakes exactly that test fail, then passes again once restored — as the issue's Test Coverage Requirements ask.packages/**YAML +test/**, both outside Codecov'scoverage.include, so no patch-coverage gate applies.