fix(gate): stop fork false-close + neutral silent-stuck (harm-stop) - #1138
Merged
Conversation
THE dominant contributor-flood failure (robustness audit). Two disposition bugs killed/stranded good PRs: 1. FORK FALSE-CLOSE: ciState='unverified' (a fork whose Actions await maintainer approval, or unreadable check-runs) made reviewGood=false, so a CONTRIBUTOR with a passing gate was one-shot CLOSED citing 'CI could not be verified' — and re-closed every push. FIX: willClose now fires ONLY on a REAL adverse signal — a confirmed gate FAILURE, a red required CI (ciFailed), or a base CONFLICT. Unverified / not-yet-mergeable is HELD for review, never killed. (Owner/automation still never close; guarded paths still held.) 2. NEUTRAL SILENT-STUCK: a non-confirmed contributor PR with any advisory blocker gets conclusion='neutral', and the planner returned [] immediately — no label, no disposition — so the PR looked 'unreviewed forever' (the metagraphed #1551/#1554 class). FIX: only SKIPPED short-circuits; a NEUTRAL gate now FLOWS to the disposition so the PR is surfaced with a label + held (never silently undecided). Neutral is NOT auto-merged (that trust/policy decision is deferred, not bundled here). Full suite green (3589). Updated agent-actions + queue tests that asserted the old (harmful) close/silent behavior.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1138 +/- ##
=======================================
Coverage 94.77% 94.77%
=======================================
Files 156 156
Lines 18855 18855
Branches 6826 6826
=======================================
Hits 17869 17869
Misses 404 404
Partials 582 582 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JSONbored
added a commit
that referenced
this pull request
Jun 24, 2026
…he residual false-close) (#1143) The harm-stop (#1138) held ciState='unverified' fork PRs but MISSED this path: a fork awaiting maintainer 'Approve and run' surfaces its required checks with conclusion='action_required', which CI_FAILING_CONCLUSIONS folded into failingDetails → ciState='failed' → the agent still one-shot CLOSED the fork citing 'CI is failing', even though no check ever ran. Removing 'action_required' from the failing set lets it fall through to anyPending → ciState='pending' → the PR is DEFERRED/held, never closed, until its runs are approved (manually or by upcoming fork CI auto-approval). Full suite green (3608).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dominant contributor-flood failure from the robustness audit. (1) Unverified CI (fork awaiting approval) no longer auto-CLOSES contributor PRs — held for review; close fires only on real gate-failure / red-CI / conflict. (2) Neutral gate no longer returns an empty plan (silent-stuck) — it flows to held+labeled. Neutral auto-merge deliberately NOT included (separate policy). Full suite green (3589).