fix(ci): treat fork action_required as pending, not failed (residual false-close) - #1143
Merged
Conversation
…he residual false-close) The harm-stop (#1138) held ciState='unverified' fork PRs but MISSED this path: a fork awaiting maintainer 'Approve and run' surfaces its required checks with conclusion='action_required', which CI_FAILING_CONCLUSIONS folded into failingDetails → ciState='failed' → the agent still one-shot CLOSED the fork citing 'CI is failing', even though no check ever ran. Removing 'action_required' from the failing set lets it fall through to anyPending → ciState='pending' → the PR is DEFERRED/held, never closed, until its runs are approved (manually or by upcoming fork CI auto-approval). Full suite green (3608).
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1143 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 156 156
Lines 18872 18872
Branches 6833 6833
=======================================
Hits 17887 17887
Misses 404 404
Partials 581 581 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the harm-stop (#1138). A fork PR awaiting maintainer 'Approve and run' has required checks with conclusion=
action_required;CI_FAILING_CONCLUSIONSfolded that into failed →ciState='failed'→ the agent still auto-closed the fork as 'CI failing' even though nothing ran. Now it falls through toanyPending→pending→ deferred/held, never closed. Full suite green (3608).