feat(miner-portfolio): add pure portfolio queue primitives - #2545
Conversation
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-02 10:40:39 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 4 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2545 +/- ##
==========================================
+ Coverage 95.97% 95.99% +0.02%
==========================================
Files 226 230 +4
Lines 25526 25888 +362
Branches 9289 9411 +122
==========================================
+ Hits 24498 24852 +354
- Misses 417 425 +8
Partials 611 611
🚀 New features to boost your workflow:
|
50934a4 to
0967952
Compare
0967952 to
34bf515
Compare
Summary
PortfolioQueuebookkeeping primitives to@jsonbored/gittensory-enginefor#2326enqueueItem,dequeueItem, andnextEligibleItemswith repo bucketing, global/per-repo WIP caps, and stable cross-repo alternationScope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
origin/main:npx vitest run test/unit/portfolio-queue.test.tsnpm --workspace @jsonbored/gittensory-engine run testnpm run db:migrations:checknpm run test:coverageretry on an earlier rebased attempt hit an unrelatedtest/unit/queue-trends.test.tsflake; the file passed on isolated retry.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
No visible UI changes.
Notes
packages/gittensory-engine/src/portfolio/queue.tsat 100% lines and 100% branches.