fix(signals): require a real shared file before path-driven PR collisions cluster - #2696
Merged
Conversation
…ions cluster A repo-wide shadow test of buildCollisionReport against the live open-PR queue found that folding changedFiles into the same bag-of-words scorer as titles/labels let generic directory-segment tokens (src, review, test, unit) drive false-positive collisions between unrelated PRs: 12 of 17 newly-flagged pairs shared zero actual files. Require an actual shared, non-lockfile file path when a match is driven by path terms alone, mirroring the existing same-author re-score guard. Re-validated: every remaining flagged pair is backed by a real shared file. Enables GITTENSORY_OPEN_PR_FILE_COLLISION now that the false-positive rate is resolved.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2696 +/- ##
========================================
Coverage 96.15% 96.15%
========================================
Files 240 240
Lines 26867 26967 +100
Branches 9751 9789 +38
========================================
+ Hits 25833 25930 +97
- Misses 424 426 +2
- Partials 610 611 +1
🚀 New features to boost your workflow:
|
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildCollisionReportagainst the live open-PR queue for JSONbored/gittensory (16 real open PRs) after feat(signals): flag open-vs-open PR file-path collisions #2654 shipped open-PR file-collision detection flag-gated OFF. WithchangedFilesfolded into the same bag-of-words scorer as titles/labels, 20 clusters were flagged vs. 3 without path terms — but 12 of the 17 new ones shared zero actual files, driven purely by generic directory-segment tokens (src,review,test,unit) that recur across nearly every PR in a consistently-organized repo.diffFilePriorityfromsrc/review/review-diff.ts) before letting it cluster. Mirrors the existing same-author guard's "re-score without paths" pattern.packages/gittensory-mcp/bin/gittensory-mcp.js— a genuine merge-conflict warning).GITTENSORY_OPEN_PR_FILE_COLLISIONnow that the false-positive rate is resolved.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlint(vianpm run test:ci)npm run typechecknpm run test:coveragelocally, unsharded (358 files, 6859 tests passed; engine.ts 99.36% stmts / 98.28% branch)npm run test:workers(vianpm run test:ci)npm run build:mcp(vianpm run test:ci)npm run test:mcp-pack(vianpm run test:ci)npm run ui:openapi:check(vianpm run test:ci)npm run ui:lint(vianpm run test:ci)npm run ui:typecheck(vianpm run test:ci)npm run ui:build(vianpm run test:ci)npm audit --audit-level=moderate— 0 vulnerabilitiesSafety
UI Evidencesection below. (N/A — no visible UI change)Notes
worker-configuration.d.tsregenerated vianpm run cf-typegento reflect theGITTENSORY_OPEN_PR_FILE_COLLISIONliteral-type flip to"true".