Skip to content

fix(signals): drop the stale v8-ignore on buildCollisionReport's pairwise loop - #2714

Merged
JSONbored merged 1 commit into
mainfrom
fix/collision-loop-coverage-report
Jul 3, 2026
Merged

fix(signals): drop the stale v8-ignore on buildCollisionReport's pairwise loop#2714
JSONbored merged 1 commit into
mainfrom
fix/collision-loop-coverage-report

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

Scope

Validation

  • npm run typecheck
  • npm run test:coverage locally, unsharded — full suite green, engine.ts 99.25%/97.94% branch, no new uncovered lines
  • Targeted re-run of test/unit/signals-v2.test.ts, signals-coverage.test.ts, signals.test.ts — all pass

Safety

  • No secrets/private data exposed.
  • N/A — no auth/UI/API/docs surface touched.

Notes

  • Comment-only change; this is purely fixing coverage reporting accuracy for the diff, not adding new tested behavior.

…wise loop

codecov/patch flagged the new path-overlap guard at 66.66% because the whole
pairwise loop was wrapped in a v8-ignore comment that predates real per-branch
test coverage for it. Confirmed via the full unsharded suite that removing it
reveals zero new gaps (engine.ts stays at 99.25%/97.94% branch, same 3
pre-existing unrelated uncovered lines) — the loop is fully exercised by the
existing + new collision tests, the ignore was just stale.
@JSONbored JSONbored self-assigned this Jul 3, 2026
@JSONbored
JSONbored merged commit 459df50 into main Jul 3, 2026
8 checks passed
@JSONbored
JSONbored deleted the fix/collision-loop-coverage-report branch July 3, 2026 07:21
@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.11%. Comparing base (dc90617) to head (e3a7340).
⚠️ Report is 14 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2714      +/-   ##
==========================================
- Coverage   96.13%   96.11%   -0.02%     
==========================================
  Files         241      241              
  Lines       27033    27057      +24     
  Branches     9822     9834      +12     
==========================================
+ Hits        25988    26006      +18     
  Misses        433      433              
- Partials      612      618       +6     
Files with missing lines Coverage Δ
src/signals/engine.ts 97.35% <ø> (-0.32%) ⬇️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant