fix(signals): drop the stale v8-ignore on buildCollisionReport's pairwise loop - #2714
Merged
Merged
Conversation
…wise loop codecov/patch flagged the new path-overlap guard at 66.66% because the whole pairwise loop was wrapped in a v8-ignore comment that predates real per-branch test coverage for it. Confirmed via the full unsharded suite that removing it reveals zero new gaps (engine.ts stays at 99.25%/97.94% branch, same 3 pre-existing unrelated uncovered lines) — the loop is fully exercised by the existing + new collision tests, the ignore was just stale.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2714 +/- ##
==========================================
- Coverage 96.13% 96.11% -0.02%
==========================================
Files 241 241
Lines 27033 27057 +24
Branches 9822 9834 +12
==========================================
+ Hits 25988 26006 +18
Misses 433 433
- Partials 612 618 +6
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildCollisionReportwas wrapped in a/* v8 ignore start/stop */comment that predates real per-branch test coverage for it.engine.tsstays at 99.25% stmts / 97.94% branch, with the exact same 3 pre-existing, unrelated uncovered lines (just shifted by the 2 deleted comment lines). The loop is fully exercised by the existing + fix(signals): require a real shared file before path-driven PR collisions cluster #2696's new collision tests; the ignore was simply stale.Scope
Validation
npm run typechecknpm run test:coveragelocally, unsharded — full suite green, engine.ts 99.25%/97.94% branch, no new uncovered linestest/unit/signals-v2.test.ts,signals-coverage.test.ts,signals.test.ts— all passSafety
Notes