test(ci): match workflow-runner-labels to the github-hosted validation move - #2827
Merged
Merged
Conversation
…n move #2825 moved validate-code and the scheduled audit job from the self-hosted gittensory runner pool to ubuntu-latest while the self-hosted review stack is CPU constrained, but left this drift guard pinned to the old self-hosted expectations, breaking it on main for every branch cut afterward.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2827 +/- ##
=======================================
Coverage ? 96.20%
=======================================
Files ? 253
Lines ? 27781
Branches ? 10093
=======================================
Hits ? 26726
Misses ? 433
Partials ? 622 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#2825movedvalidate-code(ci.yml) and the scheduledauditjob (audit.yml) from the self-hosted[self-hosted, gittensory]runner pool toubuntu-latestwhile the self-hosted review stack is CPU constrained, but didn't updatetest/unit/workflow-runner-labels.test.ts, which still asserted the old self-hosted-pool expectations.mainwith a failing unit test right now, which would blocknpm run test:ci(and thevalidaterequired check) for any unrelated PR cut from currentmain.runs-on:line inci.yml/audit.ymlstays onubuntu-latest, none select the self-hosted pool.selfhost.yml's own (unrelated, untouched) assertions are unchanged.Scope
test/unit/workflow-runner-labels.test.ts), nosrc/**touched — no Codecov patch-coverage obligation.wantedPaths, narrow, single concern.Validation
npm run typechecknpx vitest run test/unit/workflow-runner-labels.test.ts(3/3 passing)npx vitest run test/unit/check-migrations-script.test.ts test/unit/check-schema-drift-script.test.ts(unrelated pre-existing failures in the same full-suite run, traced to a stalenode_modules/.bin/tsxin this worktree, not this change; resolved bynpm ci, unaffected by this diff)npm audit --audit-level=moderate(0 vulnerabilities)git diff --check(clean)Safety