test(ci): sync workflow-runner-labels with the github-hosted runner migration - #2831
test(ci): sync workflow-runner-labels with the github-hosted runner migration#2831ultrahighsuper wants to merge 1 commit into
Conversation
…igration JSONbored#2825 moved every CI/audit job off the self-hosted gittensory pool onto GitHub-hosted ubuntu-latest runners but left workflow-runner-labels.test.ts asserting the removed self-hosted runs-on — so the suite fails on main (the ci.yml trusted-pool expression is gone, and audit.yml is no longer self-hosted). Update the assertions to the github-hosted policy: no job runs-on may target the self-hosted/gittensory pool, and every job runs on ubuntu-latest. Also normalize CRLF so the job slices are stable on either line-ending checkout.
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-03 21:13:56 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 5 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Problem:
mainis red#2825 ("ci(runners): use github-hosted validation") moved every CI/audit job off the self-hosted
gittensorypool onto GitHub-hostedubuntu-latestrunners, but did not updatetest/unit/workflow-runner-labels.test.ts, which still asserts the removed self-hosted configuration. The suite now fails onmain:…'["self-hosted","gittensory"]'…appears exactly once; ci(runners): use github-hosted validation #2825 removed it, so it appears zero times.runs-on: [self-hosted, gittensory]; ci(runners): use github-hosted validation #2825 changed it toruns-on: ubuntu-latest.Both fail on every PR's
validate-code, so the gate's required check is red repo-wide.Fix (test-only)
Sync the assertions with #2825's github-hosted policy, keeping the test meaningful (it still fails if the self-hosted pool ever returns):
runs-onmay target the self-hosted/gittensory pool — in either the YAML[self-hosted, gittensory]array or the JSON"self-hosted"fork-aware expression (aself-hostedmention may still legitimately survive in a comment or agittensory-*path glob, so the assertions match theruns-onforms, not the whole file). Every job —changes,validate-code,security,validate— is assertedruns-on: ubuntu-latest. The structural guards are unchanged (singlevalidate-codebuild/test job, gateneeds: [changes, validate-code, security], no fanned-out per-language jobs).runs-on: ubuntu-latestand no self-hostedruns-on.Also normalizes CRLF→LF in the file reader so the
\n-anchored job slices are stable regardless of checkout line endings.No workflow files are touched — this only makes the test reflect the already-merged, intentional runner migration. Verified the full
workflow-runner-labelssuite (3 tests) passes andtsc --noEmitis clean.No linked issue: issue creation is unavailable for this account.