Skip to content

test(queue): stop asserting configuration has no dispatch handler - #3997

Closed
JSONbored wants to merge 1 commit into
mainfrom
fix/queue-test-configuration-handler-drift
Closed

test(queue): stop asserting configuration has no dispatch handler#3997
JSONbored wants to merge 1 commit into
mainfrom
fix/queue-test-configuration-handler-drift

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

  • Main is currently red: test/unit/queue.test.ts's "a PR command surface — @gittensory review / pause / resume / resolve / help / configuration / explain #1960 action-command verb with no dispatch handler wired yet ... is bailed out of the Q&A answer-card path" test used @gittensory configuration as its example of an unwired verb, but feat(commands): add @gittensory configuration effective-config command (#2168) #3983 (merged since) wired a real maybeProcessConfigurationCommand handler for it — so a bare "configuration" comment now correctly gets a real response, and the test's expect(calls.comments).toBe(0) assertion no longer holds.
  • Switches the test's example to @gittensory pausepause is defined in GITTENSORY_ACTION_COMMAND_CATALOG but, unlike gate-override/resolve/configuration/plan, has no maybeProcess*Command dispatch handler wired into processors.ts's webhook chain yet, so it's still a valid example of the behavior this test actually verifies.

Scope

  • Test-only change, one file, one assertion's example input.

Validation

  • npx tsc --noEmit — clean.
  • npx vitest run test/unit/queue.test.ts — 659/659 pass.

Safety

  • No secrets/wallets/hotkeys/trust-scores/reward-values touched.
  • No changelog edit; no site//CNAME/lovable changes.

#3983 wired a real maybeProcessConfigurationCommand handler for
"@gittensory configuration", so this test's premise (a verb with no
handler bails cleanly out of the Q&A answer-card path) no longer holds
for that example. Switches to "pause", a still-genuinely-unwired
action-command in the same catalog.
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

1 similar comment
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@JSONbored JSONbored self-assigned this Jul 7, 2026
@JSONbored JSONbored closed this Jul 7, 2026
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@c585c41). Learn more about missing BASE report.
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3997   +/-   ##
=======================================
  Coverage        ?   93.74%           
=======================================
  Files           ?      379           
  Lines           ?    35191           
  Branches        ?    12900           
=======================================
  Hits            ?    32990           
  Misses          ?     1583           
  Partials        ?      618           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JSONbored
JSONbored deleted the fix/queue-test-configuration-handler-drift branch July 19, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant