test(queue): stop asserting configuration has no dispatch handler - #3997
Closed
JSONbored wants to merge 1 commit into
Closed
test(queue): stop asserting configuration has no dispatch handler#3997JSONbored wants to merge 1 commit into
JSONbored wants to merge 1 commit into
Conversation
#3983 wired a real maybeProcessConfigurationCommand handler for "@gittensory configuration", so this test's premise (a verb with no handler bails cleanly out of the Q&A answer-card path) no longer holds for that example. Switches to "pause", a still-genuinely-unwired action-command in the same catalog.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
1 similar comment
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3997 +/- ##
=======================================
Coverage ? 93.74%
=======================================
Files ? 379
Lines ? 35191
Branches ? 12900
=======================================
Hits ? 32990
Misses ? 1583
Partials ? 618 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/unit/queue.test.ts's "a PR command surface — @gittensory review / pause / resume / resolve / help / configuration / explain #1960 action-command verb with no dispatch handler wired yet ... is bailed out of the Q&A answer-card path" test used@gittensory configurationas its example of an unwired verb, but feat(commands): add @gittensory configuration effective-config command (#2168) #3983 (merged since) wired a realmaybeProcessConfigurationCommandhandler for it — so a bare "configuration" comment now correctly gets a real response, and the test'sexpect(calls.comments).toBe(0)assertion no longer holds.@gittensory pause—pauseis defined inGITTENSORY_ACTION_COMMAND_CATALOGbut, unlikegate-override/resolve/configuration/plan, has nomaybeProcess*Commanddispatch handler wired intoprocessors.ts's webhook chain yet, so it's still a valid example of the behavior this test actually verifies.Scope
Validation
npx tsc --noEmit— clean.npx vitest run test/unit/queue.test.ts— 659/659 pass.Safety
site//CNAME/lovablechanges.