Skip to content

test(queue): stop asserting configuration has no dispatch handler #3997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JSONbored wants to merge 1 commit into from
Closed

test(queue): stop asserting configuration has no dispatch handler #3997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions test/unit/queue.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22797,13 +22797,15 @@ describe("queue processors", () => {
installation: { id: 123, account: { login: "JSONbored", id: 1, type: "User" } },
repository: { name: "gittensory", full_name: "JSONbored/gittensory", private: false, owner: { login: "JSONbored" } },
issue: { number: 93, title: "Not yet wired", state: "open", user: { login: "contributor" }, pull_request: {} },
comment: { id: 900, body: "@gittensory configuration", author_association: "OWNER", user: { login: "maintainer", type: "User" } },
comment: { id: 900, body: "@gittensory pause", author_association: "OWNER", user: { login: "maintainer", type: "User" } },
sender: { login: "maintainer", type: "User" },
},
});

// No handler claims a bare "configuration" comment yet (its dispatch lands in a follow-up bounty), so the Q&A
// answer-card path must bail rather than post a stray "help" card or any other Q&A comment.
// "pause" is a recognized action-command (GITTENSORY_ACTION_COMMAND_CATALOG) but has no maybeProcess*Command
// dispatch handler wired yet, unlike gate-override/resolve/configuration/plan -- its dispatch lands in a
// follow-up bounty, so the Q&A answer-card path must bail rather than post a stray "help" card or any other
// Q&A comment.
expect(calls.comments).toBe(0);
const feedback = await env.DB.prepare("select id from audit_events where event_type = ?").bind("github_app.agent_command_feedback_prompted").first<{ id: string }>();
expect(feedback ?? null).toBeNull();
Expand Down