ci(ui-preview): drop prod custom-domain route from the preview deploy config - #645
Conversation
… config The trusted preview config embedded the production custom domain (routes: gittensory.aethereal.dev, custom_domain: true). It is inert under `wrangler versions upload` (a 0%-traffic preview version applies no routes), but it was a latent footgun: if that command were ever changed to `wrangler deploy`, fork-built code would immediately seize the production domain at 100% traffic. A workers.dev preview neither needs nor uses the route, so removing it eliminates that path; a comment now warns against re-adding it. Defense-in-depth follow-up to the fork-safe preview pipeline (#643), flagged by an adversarial security audit of that pipeline.
|
gittensory · advisory review Reviewed 1 changed file(s) — two independent AI reviewers. Suggested action: ✅ Safe to merge — both reviewers found no blocking issues. Reviewer A · Suggestions
Worth double-checking
Reviewer B · No blocking issues spotted. |
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
What
Removes the production custom-domain
routesblock from the preview Wrangler config written inui-preview-deploy.yml:"vars": { "VITE_GITTENSORY_API_ORIGIN": "https://gittensory-api.aethereal.dev" }, - "routes": [ - { "pattern": "gittensory.aethereal.dev", "custom_domain": true } - ], "main": "index.mjs",Why (defense-in-depth)
Follow-up to the fork-safe preview pipeline (#643), flagged by an adversarial security audit of that pipeline.
The preview deploy uses
wrangler versions upload, which creates a 0%-traffic preview version (aworkers.devURL) and applies no routes — so the production custom domain in the config was already inert. But it was a latent footgun: if anyone ever changed that command towrangler deploy(or addedwrangler triggers deploy), the fork-built bundle would immediately seizegittensory.aethereal.devat 100% traffic, since custom domains are single-owner/account-scoped.Removing the route from the preview config eliminates that path entirely (a workers.dev preview neither needs nor uses it), and a comment now warns against re-adding it. No behavior change to the preview pipeline.
Validation
npm run actionlint— cleanvars→main); no other keys touched.Notes