Skip to content

ci(ui-preview): drop prod custom-domain route from the preview deploy config #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jun 13, 2026
Merged

ci(ui-preview): drop prod custom-domain route from the preview deploy config #645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions .github/workflows/ui-preview-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,11 @@ jobs:
echo "Artifact validated: no symlinks, expected SSR structure, allowlisted file types only."

# The Wrangler config is written HERE (trusted) — never taken from the PR — so a fork cannot
# control bindings, routes, or vars. It points at the downloaded built bundle.
# control bindings, routes, or vars. It points at the downloaded built bundle. It deliberately
# OMITS the production custom-domain route: `wrangler versions upload` creates a 0%-traffic
# preview version (a workers.dev URL) and applies no routes, so the route is unused here — and
# omitting it guarantees that even a future switch to `wrangler deploy` could never point
# fork-built code at the production domain. Do not add a `routes` block to this preview config.
- name: Write trusted preview Wrangler config
if: steps.cfg.outputs.ready == 'true'
run: |
Expand Down Expand Up @@ -138,12 +142,6 @@ jobs:
"vars": {
"VITE_GITTENSORY_API_ORIGIN": "https://gittensory-api.aethereal.dev"
},
"routes": [
{
"pattern": "gittensory.aethereal.dev",
"custom_domain": true
}
],
"main": "index.mjs",
"assets": {
"binding": "ASSETS",
Expand Down