Skip to content

🛠 Tooling: CI doesn't catch a project losing all of its test files #336

Description

@JoshuaKGoldberg

Tooling Report Checklist

  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my request.
  • This is the appropriate issue form for the tooling issue I would like to report.

Expected

CI should fail when a project that runs Jest loses its test files.

Actual

It doesn't. #288 deleted all three the-typeinator test files with every check green, and the breakage sat on main for four months (#322, #323, #324).

Two gaps:

  1. Test, Solutions, and Tsc pick projects from changed-files's all_changed_files, which is ACMR — deletions excluded. The typeinator's only change was three deletions, so it never ran. Jest exits 1 with no test files, so the check would have failed had it executed.
  2. files.test.ts runs unfiltered on every PR but never asserts a test file exists.

Additional Info

scripts.test === "jest" is a clean discriminator: all 18 Jest projects have a test file in every step, and the 12 tsc projects have none by design.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

accepting prsYes please, send a pull request! ♥area: toolingChanges around repository management, such as CI, formatting, linting, and releases.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions