chore: update most deps to latest (May 8 2025) - #288
Merged
Merged
Conversation
This was referenced May 9, 2025
3 tasks done
JoshuaKGoldberg
added a commit
that referenced
this pull request
Sep 22, 2026
The three `index.test.js` files under `the-typeinator` were deleted in 2db4cdb ("chore: update most deps to latest (May 8 2025)", #288), a dependency bump that otherwise only reformatted files. Nothing replaced them, so `npm run test -- 1 --watch` -- the command the project README and learningtypescript.com both tell readers to run -- reports "No tests found, exiting with code 0". Restores all three files as they were at 2db4cdb^. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Sep 22, 2026
JoshuaKGoldberg
added a commit
that referenced
this pull request
Sep 22, 2026
Two gaps let #288 delete all three `the-typeinator` test files without any check going red, leaving the project broken on `main` for months (#322, #323, #324). The `Test`, `Solutions`, and `Tsc` workflows pick which projects to run from `changed-files`'s `all_changed_files` output, which is ACMR and so excludes deletions. The typeinator's only change in that PR was three deletions, so the project never ran. Switches all three workflows to `all_modified_files` (ACMRD), which includes them. `files.test.ts` runs on every PR with no changed-files filtering, but only validated `_category_.json`, `README.md`, `tsconfig.json`, and `package.json` -- a step directory with no test file passed. Adds an assertion that every step (or `src`) of a project contains a test file. A project's `test` script is the discriminator: `tsc` projects are type-checking exercises and legitimately ship no tests, while all 18 `jest` projects currently have a test file in every step, so the new assertion adds no false positives. Verified by re-deleting the three typeinator test files, which now fails `files.test.ts` with one error per step. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JoshuaKGoldberg
added a commit
that referenced
this pull request
Sep 22, 2026
Two gaps let #288 delete all three `the-typeinator` test files without any check going red, leaving the project broken on `main` for months (#322, #323, #324). The `Test`, `Solutions`, and `Tsc` workflows pick which projects to run from `changed-files`'s `all_changed_files` output, which is ACMR and so excludes deletions. The typeinator's only change in that PR was three deletions, so the project never ran. Switches all three workflows to `all_modified_files` (ACMRD), which includes them. `files.test.ts` runs on every PR with no changed-files filtering, but only validated `_category_.json`, `README.md`, `tsconfig.json`, and `package.json` -- a step directory with no test file passed. Adds an assertion that every step (or `src`) of a project contains a test file. A project's `test` script is the discriminator: `tsc` projects are type-checking exercises and legitimately ship no tests, while all 18 `jest` projects currently have a test file in every step, so the new assertion adds no false positives. Verified by re-deleting the three typeinator test files, which now fails `files.test.ts` with one error per step. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
Runs
ncu -u, then revertscapital-case's update as the newest version is ESM-only.