Skip to content

fix(nvenc): dynamic nv codec sdk selection - #5451

Merged
ReenigneArcher merged 3 commits into
masterfrom
fix/dynamic-nv-codec-sdk-selection
Jul 27, 2026
Merged

ReenigneArcher merged 3 commits into
masterfrom
fix/dynamic-nv-codec-sdk-selection

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Jul 25, 2026

Copy link
Copy Markdown
Member

Description

Dynamic SDK selection for nvenc.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@ReenigneArcher
ReenigneArcher force-pushed the fix/dynamic-nv-codec-sdk-selection branch from b493dc2 to 1631383 Compare July 25, 2026 17:27
@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.06977% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.37%. Comparing base (7cb9207) to head (4c13ef9).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/windows/display_vram.cpp 10.00% 6 Missing and 3 partials ⚠️
src/nvenc/nvenc_dynamic_factory.cpp 84.31% 1 Missing and 7 partials ⚠️
src/nvenc/nvenc_dynamic_factory.h 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5451      +/-   ##
==========================================
+ Coverage   26.89%   27.37%   +0.47%     
==========================================
  Files         111      109       -2     
  Lines       25410    24703     -707     
  Branches    11235    10918     -317     
==========================================
- Hits         6835     6762      -73     
- Misses      14634    15586     +952     
+ Partials     3941     2355    -1586     
Flag Coverage Δ
Archlinux 0.00% <0.00%> (ø)
FreeBSD-aarch64 ?
FreeBSD-amd64 13.74% <100.00%> (+0.48%) ⬆️
Homebrew-macos-14 21.35% <100.00%> (+1.01%) ⬆️
Homebrew-macos-15 22.02% <100.00%> (+1.04%) ⬆️
Homebrew-macos-26 22.15% <100.00%> (+1.05%) ⬆️
Homebrew-ubuntu-24.04 13.35% <100.00%> (+0.41%) ⬆️
Linux-AppImage 12.67% <100.00%> (+0.39%) ⬆️
Windows-AMD64 16.33% <66.23%> (+1.14%) ⬆️
Windows-ARM64 14.17% <64.38%> (+0.91%) ⬆️
macOS-arm64 18.70% <100.00%> (+0.95%) ⬆️
macOS-x86_64 19.41% <100.00%> (+0.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/nvenc/nvenc_d3d11_interface.h 100.00% <100.00%> (ø)
src/nvenc/nvenc_encoder.h 100.00% <100.00%> (ø)
src/nvenc/nvenc_shared_dll.h 100.00% <100.00%> (ø)
src/nvenc/nvenc_version.h 100.00% <100.00%> (ø)
src/platform/common.h 33.59% <100.00%> (ø)
src/video.cpp 53.86% <ø> (ø)
src/nvenc/nvenc_dynamic_factory.h 0.00% <0.00%> (ø)
src/nvenc/nvenc_dynamic_factory.cpp 84.31% <84.31%> (ø)
src/platform/windows/display_vram.cpp 10.20% <10.00%> (-0.11%) ⬇️

... and 49 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb9207...4c13ef9. Read the comment docs.

@ReenigneArcher
ReenigneArcher force-pushed the fix/dynamic-nv-codec-sdk-selection branch 3 times, most recently from beeed21 to 9138beb Compare July 25, 2026 23:05
@ReenigneArcher
ReenigneArcher force-pushed the fix/dynamic-nv-codec-sdk-selection branch from 919f9d8 to 4c13ef9 Compare July 26, 2026 01:04
@ReenigneArcher
ReenigneArcher marked this pull request as ready for review July 26, 2026 01:04
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v2026.516.143833 broke hardware enc on older nvidia cards

1 participant