Fix: namespace, improve logging

[AngeloTadeucci]

Summary by CodeRabbit

• Bug Fixes
  • Improved error logging when adding items to inventory, providing more detailed information for troubleshooting.
• Chores
  • Updated internal namespaces for better consistency and organization.
  • Adjusted project dependencies to refine asset management.

[coderabbitai]

Walkthrough

The changes primarily update namespace declarations for several manager classes, enhance error logging in inventory management, adjust project file package reference attributes, and add or remove using directives for improved clarity and organization. No functional or logic changes are introduced to the core codebase.

Changes

File(s)	Change Summary
Maple2.Server.Game/Manager/BuffManager.cs Maple2.Server.Game/Manager/PetManager.cs Maple2.Server.Game/Manager/SkillManager.cs Maple2.Server.Game/Manager/ConfigManager.cs	Corrected namespace declarations from .Manager.Config to .Manager; updated or added using directives as needed.
Maple2.Server.Game/Manager/Items/InventoryManager.cs	Enhanced error logging for inventory item addition failures to include more diagnostic context.
Maple2.Server.Game/Maple2.Server.Game.csproj	Modified IronPython.StdLib package reference to exclude content files and mark assets as private.
Maple2.Server.Game/PacketHandlers/PetHandler.cs	Added using directive for Maple2.Server.Game.Manager.

Suggested reviewers

• Zintixx

Poem

Hopping through namespaces, neat and precise,
The managers gather, their code looking nice.
Logs now speak clearer when items go astray,
Project files tidy, content kept at bay.
With every small hop, the code grows more bright—
A rabbit’s delight in the soft morning light!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

Maple2.Server.Game/PacketHandlers/PetHandler.cs (1)

7-7: Remove unused using directive
The using Maple2.Server.Game.Manager.Config; import is no longer required after moving classes to the .Manager namespace and can be safely removed to reduce clutter.

Maple2.Server.Game/Manager/SkillManager.cs (1)

5-5: Remove unused using directive
The using Maple2.Server.Game.Manager.Config; directive is not needed in this file following the namespace change and should be removed.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 853f8be and a2c25c0.

📒 Files selected for processing (7)

• Maple2.Server.Game/Manager/BuffManager.cs (1 hunks)
• Maple2.Server.Game/Manager/ConfigManager.cs (1 hunks)
• Maple2.Server.Game/Manager/Items/InventoryManager.cs (1 hunks)
• Maple2.Server.Game/Manager/PetManager.cs (1 hunks)
• Maple2.Server.Game/Manager/SkillManager.cs (1 hunks)
• Maple2.Server.Game/Maple2.Server.Game.csproj (1 hunks)
• Maple2.Server.Game/PacketHandlers/PetHandler.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: build
• GitHub Check: build

🔇 Additional comments (7)

Maple2.Server.Game/PacketHandlers/PetHandler.cs (1)

6-6: Import updated namespace
The new using Maple2.Server.Game.Manager; directive correctly brings the refactored manager classes into scope.

Maple2.Server.Game/Manager/BuffManager.cs (1)

13-13: Namespace alignment
The namespace has been correctly updated to Maple2.Server.Game.Manager, aligning with the other manager classes post-refactor.

Maple2.Server.Game/Manager/SkillManager.cs (1)

10-10: Namespace alignment
Updated the namespace to Maple2.Server.Game.Manager to reflect the new location of the SkillManager class.

Maple2.Server.Game/Manager/PetManager.cs (1)

13-13: Namespace alignment
The namespace has been updated to Maple2.Server.Game.Manager, consistent with the other manager classes after the refactoring.

Maple2.Server.Game/Maple2.Server.Game.csproj (1)

28-29: Refine IronPython.StdLib package reference
Excluding contentFiles and marking the package as PrivateAssets="all" ensures that only the necessary runtime assets are included and prevents unintended propagation to consuming projects.

Maple2.Server.Game/Manager/ConfigManager.cs (1)

8-8: Good addition of using directive for namespace transition.

The added using directive ensures continued access to types in the Config namespace after the namespace reorganization.

Maple2.Server.Game/Manager/Items/InventoryManager.cs (1)

40-41: Excellent enhancement to error logging for debugging inventory issues.

The additional diagnostic information (Size, OpenSlots, Count) alongside the item Uid will significantly help identify the root cause when item addition fails during inventory loading. This improvement will make troubleshooting inventory-related issues much more efficient.