Negative control for T-1502 — do not merge - #763
Closed
MongLong0214 wants to merge 4 commits into
Closed
Conversation
Pushing the v1.1.3 tag printed `notes mirror (origin) failed: spawnSync git ETIMEDOUT`. Nothing was wrong with the transport, and nothing needed doing that the rest of the line did not already say -- but the sentence names the call that returned rather than the decision that was made, so it reads as git having failed and sends whoever gets it to look at a remote that is fine. The two seconds are this hook's. A notes mirror is auxiliary to a branch push, so the budget exists to stop an offline push feeling stuck, and declining to wait is the hook working. `spawnSync` had no way to say that, and the raw code reached the operator unchanged. The line now says whose budget ran out, and interpolates the value from `PRE_PUSH_NOTES_SYNC_TIMEOUT_MS` so the sentence cannot drift from the constant it describes. Every other failure detail is untouched -- a refused connection still reports as a refused connection, because that one is about the transport. This is #746 in a second hook: a message accurate about the mechanism and wrong about the situation costs more than a vague one. Limit: only ETIMEDOUT is rewritten, so a transport that hangs without setting that code still surfaces its raw detail Blast: local Undo: easy Certainty: firm Record-Id: r-etimeout Provenance: authored Verified: with dist unrebuilt the extended timeout test fails naming the real string it still matched, and passes after the rebuild with all six pre-push tests green; the assertions were first added to the wrong test in the same file and a deliberately impossible expectation still passed, which is how that was caught CommitLore-Version: 2.0.0
`build:canonical` on the merged tree, so the commit that lands matches the source it lands with. The pull request carried source only, which is what a contributor on a host that cannot run a linux/amd64 Docker build can produce (#720). Limit: this proves the bundle matches this tree; whether this tree is what a reviewer wants is what the pull request is for Blast: system Undo: easy Certainty: firm Record-Id: r-canonmerge761 Provenance: authored Verified: artifact:verify passed against the regenerated manifest in the same job, before any credential was available to it CommitLore-Version: 2.0.0
Not for merge. This exists to make T-1502's negative control performable, and it is deleted once it has gone red. The control the ticket first named -- skipping `artifact:manifest` -- cannot be performed from a pull request: that step is hard-coded in a workflow loaded from the default branch, and the source-only filter refuses changes under `.github/workflows/`. A negative control nobody can run is the defect #722 named, so it was replaced with this one. `dist/commitlore.mjs` is edited by hand on top of the canonical rebuild and `src/` is untouched. CI rebuilds from source and diffs, so the edit has to surface as a failure. If it does not, "the bytes that land match the source that landed with them" is not a property this repository checks. Limit: this proves the diff catches a tampered bundle, not that every path into dist is covered Blast: local Undo: easy Certainty: firm Record-Id: r-ncontrol Provenance: authored Verified: the bundle digest moved from 6e69cc379584928a to 879e17c82c47fb14 with no change under src/ CommitLore-Version: 2.0.0
CommitLore — record lintTrailers: clean — 4 commits in Trailer violations fail this check. Active constraints are informational — they are what the repository already decided, not a verdict on this PR. |
Owner
Author
|
Went red, in the right place. Both
Closing. T-1502's second acceptance criterion is observed. |
This was referenced Aug 18, 2026
Committing dist is what makes the checkout the product — and what makes every second PR rebuild
#719
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not for merge. This is T-1502's negative control, and it is closed once it has gone red.
The control the ticket originally named — skipping
artifact:manifest— cannot be performed from a pull request. That step is hard-coded incanonical-merge.yml, which is loaded from the default branch, and the workflow's source-only filter refuses any change under.github/workflows/. A negative control nobody can run is the defect #722 named, so the ticket now names one that can be run: this.This branch is #762's canonical rebuild with
dist/commitlore.mjsedited by hand andsrc/left alone. The bundle digest moved6e69cc37…→879e17c8…with no source change behind it.CI rebuilds from source and then runs
git diff --exit-code -- dist/ installer/canonical-artifact.json. Thecheckjobs must fail. If they pass, the bytes that land match the source that landed with them is not a property this repository actually checks, and #762 proves nothing.