T-1504 closes #719, and says what it accepted to do so - #770
Merged
Conversation
All five acceptance criteria have a run behind them. The table in the ticket names which run for which, so a later reader checks rather than trusts. The last criterion arrived last and caught a defect in its own first version: the inline handoff check required the canonical branch tip to have two parents, and a real tip has one, because the rebuild commits on top of the merge whenever `dist/` changes. Every assertion I had written read the workflow as text and passed. That is why the rule lives in a script with one mutation per case now. What #719 accepted in order to close is on the issue and in the ticket rather than implied: no external contributor has taken this path yet. That is adoption evidence, and holding a correctness gate open for it would leave the work unfinished for a reason unrelated to the work. Limit: the closing evidence is six runs and one repository -- its own -- so it shows the mechanism works and not that it works for somebody else Blast: local Undo: easy Certainty: firm Record-Id: r-t1504done Provenance: authored Verified: each row in the new table names a pull request, run or commit that exists, and the five criteria were read from main rather than from the branch that wrote them CommitLore-Version: 2.0.0
CommitLore — record lintTrailers: clean — 2 commits in Trailer violations fail this check. Active constraints are informational — they are what the repository already decided, not a verdict on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All five of T-1504's rewritten acceptance criteria have a run behind them, and the ticket now names which run for which so a later reader checks rather than trusts.
src/andtest/onlye4e5154, no local buildsrc/untouched, bothcheckjobs redmainunaidedscripts/verify-canonical-handoff.mjs+ one mutation per ruleThe last row arrived last and caught a defect in its own first version — the inline check required two parents on the canonical tip, and a real tip has one. Every assertion I had written read the workflow as text and passed.
What closing accepted, stated rather than implied: no external contributor has taken this path yet. That is adoption evidence, not a correctness gate, and holding the work open for it would leave it unfinished for a reason unrelated to the work.
Limit (on the commit): the closing evidence is six runs and one repository — its own — so it shows the mechanism works, not that it works for somebody else.