Skip to content

migrate: SQA bug-fix bundle from mono-repo (nvds_logger, tracker_ReID, build.sh, BUILD.md, MR !89 Triton samples) - #3

Merged
nvankita merged 7 commits into
mainfrom
migrate/sqa-bug-fixes
May 14, 2026
Merged

nvankita merged 7 commits into
mainfrom
migrate/sqa-bug-fixes

Conversation

@nvankita

@nvankita nvankita commented May 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

Brings the GitHub repo in line with the GitLab DeepStream mono-repo main for the SQA bug-fix bundle (mono-repo MRs !87, !88, !89). PR #2 migrated most of the source tree but several files were left dangling or never copied; this PR closes those gaps and adds build infrastructure.

The top-level README.md and tools/inference_builder/ are both intentionally not modified by this PR — initial rewrite/migration commits were reverted to keep the README at the OSS template default and tools/ containing only sam2-onnx-tensorrt and yolo_deepstream.

Net diff

Three logical changes stick after the rewrite/revert pairs:

  1. src/utils/nvds_logger/ + src/utils/nvmultiobjecttracker/model/tracker_ReID/ added
  2. build.sh + BUILD.md added (post-MR !87)
  3. src/apps/sample_apps/TritonBackendEnsemble/ + src/apps/sample_apps/TritonOnnxYolo/ added + Triton sections in src/apps/sample_apps/README.md and src/utils/README.md

Commits (7 total)

# SHA Title Net effect
1 189171d migrate: add nvds_logger and tracker_ReID model docs from mono-repo ✅ kept
2 9e530a7 migrate: copy build.sh and BUILD.md from mono-repo ✅ kept
3 8bd3b97 migrate: port MR !89 Triton samples + README section additions ✅ kept
4 d3b4b10 docs(README): replace OSS template skeleton with DeepStream content ↩️ reverted by 5
5 76a583b Revert "docs(README): replace OSS template skeleton with DeepStream content" restores OSS template README
6 a6aec32 migrate: copy tools/inference_builder/ from mono-repo ↩️ reverted by 7
7 47055cb Revert "migrate: copy tools/inference_builder/ from mono-repo" restores tools/ without inference_builder

Detail on the kept commits

migrate: add nvds_logger and tracker_ReID model docs from mono-repo

src/utils/README.md (already migrated by PR #2) referenced these two paths under its "Tooling & Model Setup" section, but the files themselves were not brought over.

  • src/utils/nvds_logger/: setup_nvds_logger.sh + upstream README. Configures rsyslog to capture DeepStream DSLOG to /var/log/nvds/.
  • src/utils/nvmultiobjecttracker/model/tracker_ReID/README: SAM2 segmentation / TAO ReidentificationNet / TAO BodyPose3DNet model prep guide for the multi-object tracker.

migrate: copy build.sh and BUILD.md from mono-repo

  • build.sh (post-MR !87 — includes the nvds_msgapi adaptor loop fix that descends one level deeper than the standard src/utils/*/ loop, and handles azure_protocol_adaptor's device_client/module_client/ split).
  • BUILD.md end-user build documentation.

migrate: port MR !89 Triton samples + README section additions

  • src/apps/sample_apps/TritonBackendEnsemble/ — Triton ensemble + custom C++ backend sample. Top-level delegating Makefile wires the nvdsinferserver_custom_impl_ensemble library into build.sh's sample_apps loop. nvds_triton_cpp_custom_backend is cmake-based and intentionally not wired into build.sh.
  • src/apps/sample_apps/TritonOnnxYolo/ — ONNX YoloV3 dynamic-tensor custom-process sample.
  • src/apps/sample_apps/README.md — adds "Triton Inference Server" section.
  • src/utils/README.md — adds "Tooling & Model Setup" section indexing the two dirs from the first kept commit.

MR coverage from mono-repo

Mono-repo MR Item In this PR
!87 #1 Drop artifacts/ contents N/A — artifacts/ doesn't exist in GitHub
!87 #2 scripts/setup_nvds_logger.sh N/A — superseded by !89
!87 #3 scripts/README.md N/A — reverted by !89
!87 #4 build.sh nvds_msgapi loop ✅ folded into build.sh copy
!87 #5 README Triton Docker section ❌ deferred — root README left at OSS template
!87 #6 README Deprecated Components ❌ deferred — root README left at OSS template
!88 Drop custom Triton model-repo snippet N/A — top-level README isn't migrated yet
!89 TritonBackendEnsemble + TritonOnnxYolo
!89 nvds_logger relocation
!89 tracker_ReID model docs
!89 sample_apps/README.md Triton section
!89 src/utils/README.md Tooling section

Out of scope (separate migration work)

  • tools/auto-magic-calib/ and tools/inference_builder/ migrations
  • Project-specific top-level README.md (deferred — currently at OSS template)

Test plan

  • Locally verified mono-repo build.sh sample_apps loop builds libnvdstriton_custom_impl_ensemble.so and libnvdstriton_custom_impl_yolo.so cleanly (CUDA_VER=13.2); same Makefiles ported here.
  • core.fileMode=true on this repo — setup_nvds_logger.sh and build.sh staged at 100755.
  • Reviewer: validate Jetson (aarch64) build of the two new Triton samples.
  • Reviewer: confirm setup_nvds_logger.sh runs end-to-end.

Source

All migrated content originates from the GitLab DeepStream mono-repo main (post-MR !89; commits 0b544bc, dfa8448).

nvankita added 4 commits May 14, 2026 14:14
src/utils/README.md (already migrated) referenced these two paths under
its "Tooling & Model Setup" section, but the files themselves were not
brought over by PR #2 (DS OSS reference apps + tools migration). This
fills in the dangling references.

- src/utils/nvds_logger/: setup_nvds_logger.sh + upstream README. The
  script configures rsyslog to capture DeepStream DSLOG messages to
  /var/log/nvds/.

- src/utils/nvmultiobjecttracker/model/tracker_ReID/: upstream README
  covering SAM2 segmentation, TAO ReidentificationNet, and TAO
  BodyPose3DNet model prep for the multi-object tracker.

Source: GitLab DeepStream mono-repo, !89 (commit 0b544bc on main).
Committed-By: ankitat's Claude Agent
Codex Review: Approved:
Migrates the top-level build infrastructure from the GitLab DeepStream
mono-repo (post-MR-87 main):

- build.sh: bash driver that builds all utils, gst-utils, gst-plugins,
  sample apps, and tao apps with platform-aware CUDA_VER defaults
  (x86=13.1, aarch64/sbsa=13.0). Includes the nvds_msgapi adaptor
  loop (originally MR !87 fix #4 — descends one level deeper than the
  general src/utils loop and handles azure_protocol_adaptor's
  device_client/module_client split).

- BUILD.md: end-user build documentation covering prerequisites,
  platform support, the build flow, and the post-build install layout.

Source: GitLab DeepStream mono-repo main (build.sh from MR !87,
docs/sbsa/build-md updates from later MRs already folded in).

Committed-By: ankitat's Claude Agent
Codex Review: Approved:
Brings the remaining MR !89 content over from the mono-repo:

- src/apps/sample_apps/TritonBackendEnsemble: Triton ensemble + custom
  C++ backend sample. Top-level delegating Makefile wires the
  nvdsinferserver_custom_impl_ensemble library into build.sh's
  sample_apps loop. nvds_triton_cpp_custom_backend is cmake-based
  (external Triton repos) and is intentionally not wired into build.sh
  -- README documents the manual build.

- src/apps/sample_apps/TritonOnnxYolo: ONNX YoloV3 dynamic-tensor
  custom-process sample. Same delegating-Makefile pattern.

- src/apps/sample_apps/README.md: add Triton Inference Server section
  describing the two library-only samples and their run flow.

- src/utils/README.md: add Tooling & Model Setup section indexing
  nvds_logger and nvmultiobjecttracker/model (which were ported in the
  earlier commit on this branch and were previously dangling
  references).

Source: GitLab DeepStream mono-repo main (MR !89 + follow-up commits).
Committed-By: ankitat's Claude Agent
Codex Review: Approved:
Fills the OSS template skeleton with content from the GitLab DeepStream
mono-repo README. Sections without a clear mono-repo counterpart
(Performance, Releases & Roadmap, Contribution Guidelines, Governance &
Maintainers, Security, Support, Community, References) are left as the
template's placeholder text intentionally.

Sections filled in:
- Project title + value proposition
- Overview: repository structure tree, components list, deprecated
  components subsection (folds in MR !87's deprecation notice)
- Getting Started: prerequisites, clone+build command, link to BUILD.md
- Requirements: supported platforms, platform-specific components,
  components with external prerequisites
- Usage: Running Sample Apps section + Running with Triton Inference
  Server (Docker) section (folds in MR !87's Triton Docker docs;
  custom model-repo snippet stays absent per MR !88)
- License: OSRB tracking note

Repository-structure tree adapted to the actual GitHub-side repo (no
artifacts/ or ISSUE_TEMPLATE/; only sam2-onnx-tensorrt and
yolo_deepstream under tools/; service-maker/python/ subdir omitted --
Python lives under sources/apps/python/).

Committed-By: ankitat's Claude Agent
Codex Review: Approved:
@nvankita nvankita self-assigned this May 14, 2026
@nvankita
nvankita requested a review from nvapandya May 14, 2026 09:07
nvankita added 2 commits May 14, 2026 17:25
Brings the Inference Builder tool over as-is from the GitLab DeepStream
mono-repo. The tool generates inference pipelines and integrates them
into a microservice or standalone application from an inference config
+ OpenAPI spec.

Includes the tool's own .gitmodules registering
dependencies/triton-inference-server/common as a submodule -- left
uninitialized to match mono-repo state (the path is not on disk in the
mono-repo either, and the top-level .gitmodules in this repo is not
modified).

Source: GitLab DeepStream mono-repo main, tools/inference_builder/
(VERSION 0.2.0). 304 files, ~8 MB.

Committed-By: ankitat's Claude Agent
Codex Review: Approved:
@nvankita nvankita changed the title migrate: SQA bug-fix bundle from mono-repo (build.sh, BUILD.md, MR !89 Triton samples + nvds_logger + tracker_ReID + README) migrate: SQA bug-fix bundle + inference_builder tool from mono-repo May 14, 2026
@nvankita
nvankita force-pushed the migrate/sqa-bug-fixes branch from dea1cc2 to 47055cb Compare May 14, 2026 12:22
@nvankita nvankita changed the title migrate: SQA bug-fix bundle + inference_builder tool from mono-repo migrate: SQA bug-fix bundle from mono-repo (nvds_logger, tracker_ReID, build.sh, BUILD.md, MR !89 Triton samples) May 14, 2026
@nvankita
nvankita merged commit 847a7ac into main May 14, 2026

@nvapandya nvapandya left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall Changes looks ok. Let's merge PR.

@nvankita
nvankita deleted the migrate/sqa-bug-fixes branch May 14, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants