docs: explain fork workflow and PR scope in CONTRIBUTING - #357
Merged
NovaCode37 merged 1 commit intoSep 13, 2026
Merged
Conversation
Adds the fork/clone/push/open-PR steps that reviewers kept having to explain in threads, notes that direct pushes are refused and that a first PR waits on CI approval, and adds a Scope section so a PR does what its issue asks instead of also rewriting the thing it was adding tests for. Also asks for `Closes NovaCode37#123` in the PR body so issues close on merge. Closes NovaCode37#352
|
Thanks for the first pull request here. CI needs a maintainer to approve the run before it starts, so it may sit for a bit before anything happens. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the fork/clone/push/open-PR steps that reviewers kept having to explain in threads, notes that direct pushes are refused and that a first PR waits on CI approval, and adds a Scope section so a PR does what its issue asks instead of also rewriting the thing it was adding tests for. Also asks for
Closes #123in the PR body so issues close on merge.Closes #352
Summary
Changes
Type of change
Testing
Screenshots