Add neuralfoil and automatic conversion from obj to yaml#249
Merged
Conversation
…d polars - Move neuralfoil/kulfan cross-validation test to lib/AirfoilAero/test/runtests.jl with its own fixture (test/data/test_airfoil.dat = the former midspan foil coords, keeping the hardcoded aerosandbox/neuralfoil reference values valid). AirfoilAero gains [extras]/[targets] so it tests independently (SciML monorepo style). - Remove the kite midspan foil.dat + generated cl/cd/cm foil polars from data/ (regenerated from the .obj); gitignore them. - Remove neuralfoil_benchmark.jl + neuralfoil_polars.jl examples. - Condense multiline inline comments in the yaml loader. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
1-Bart-1
added a commit
that referenced
this pull request
Jul 13, 2026
The BodyAerodynamics reinit\! docstring gained a 4th type param (PN<:Panel{T})
via #249. Documenter's missing_docs check matches by exact typesig equality, and
the bare `reinit\!(body_aero::BodyAerodynamics)` form no longer normalizes to the
stored signature on Julia 1.12.6, so it was reported as not-included. Mirror the
method's declared signature so the typesigs match.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1-Bart-1
added a commit
that referenced
this pull request
Jul 13, 2026
…ng (#254) * Route crease_frac * Fix reinit\! @docs signature for Julia 1.12.6 doc build The BodyAerodynamics reinit\! docstring gained a 4th type param (PN<:Panel{T}) via #249. Documenter's missing_docs check matches by exact typesig equality, and the bare `reinit\!(body_aero::BodyAerodynamics)` form no longer normalizes to the stored signature on Julia 1.12.6, so it was reported as not-included. Mirror the method's declared signature so the typesigs match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Add --update/--skip-subprojects/--no-precompile to bin/install --update runs Pkg.update() instead of seeding from the .default manifest, then copies the resulting main manifest back to Manifest-v<major>.toml.default (auto-precompile skipped so the refreshed default can be committed immediately). --skip-subprojects and --no-precompile allow a fast manifest-only refresh. Mirrors the workflow in SymbolicAWEModels.jl/bin/install. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Update default manifests Regenerated via ./bin/install --update under Julia 1.11.9 and 1.12.6. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.