Route crease_frac, fix 1.12.6 docs build, add manifest --update tooling#254
Merged
Conversation
The BodyAerodynamics reinit\! docstring gained a 4th type param (PN<:Panel{T})
via #249. Documenter's missing_docs check matches by exact typesig equality, and
the bare `reinit\!(body_aero::BodyAerodynamics)` form no longer normalizes to the
stored signature on Julia 1.12.6, so it was reported as not-included. Mirror the
method's declared signature so the typesigs match.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
--update runs Pkg.update() instead of seeding from the .default manifest, then copies the resulting main manifest back to Manifest-v<major>.toml.default (auto-precompile skipped so the refreshed default can be committed immediately). --skip-subprojects and --no-precompile allow a fast manifest-only refresh. Mirrors the workflow in SymbolicAWEModels.jl/bin/install. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Regenerated via ./bin/install --update under Julia 1.11.9 and 1.12.6. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
1-Bart-1
added a commit
that referenced
this pull request
Jul 13, 2026
Resolves conflicts from #254 (crease_frac routing, manifest --update tooling): - bin/install: kept #254's version, re-removed the ControlPlots/examples_cp/ PythonCall/CondaPkg setup; the Makie extension smoke check now loads GLMakie + MakieControlPlots. - Manifest-v1.11/1.12 defaults: reseeded from #254's manifests and re-resolved to swap the plotting weakdeps (ControlPlots/PythonCall -> MakieControlPlots). - setup-test.yml: test_setup.sh already wraps julia in xvfb-run internally, so drop the outer xvfb-run wrapper (it caused nested "Xvfb failed to start"); keep libgl1-mesa-dri. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crease_fracthrough the OBJ→YAML polar pipeline.ObjWing→obj_to_yaml→generate_polar_from_coordinates→generate_aero_matricesnow forwardcrease_frac(default0.75), so the chordwise hinge location for trailing-edge-deflected polars is configurable instead of silently pinned to the default. Enables SymbolicAWEModels to passset.crease_fracfor OBJ-based wings.BodyAerodynamicsreinit!docstring gained a 4th type parameter (PN<:Panel{T}) in Add neuralfoil and automatic conversion from obj to yaml #249. Documenter'smissing_docscheck matches by exact typesig equality, and the barereinit!(body_aero::BodyAerodynamics)@docsentry no longer normalizes to the stored signature on 1.12.6, breaking the build with "1 docstring not included in the manual." The entry now mirrors the method's declared signature so the typesigs match.--updateworkflow tobin/install. New--update,--skip-subprojects, and--no-precompileflags, mirroringSymbolicAWEModels.jl/bin/install.--updaterunsPkg.update()and copies the result back toManifest-v<major>.toml.default.Verification
reinit!fix clears themissing_docserror.🤖 Generated with Claude Code