Skip to content

environments: declarative API inherits from list and collides with list's function names. #305

Description

@simbuerg

Example: copy -> buildah copy command.

This collides with the copy method of python's lists. We should rename these. The current implementation in #293 adds a _ as suffix to relevant methods.

Methods:

  • copy -> copy_
  • from (keyword) -> from_

@vulder suggested to use _layer suffix.

This fixes ambiguous naming of methods but looks horrible when used in project's declarative part:

ContainerImage(). \
  from_layer('foo'). \
  add_layer('src', 'dst'). \
  run_layer('cmd', 'arg0', 'arg1')

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions