container support: decoupled - #293
Merged
Merged
Conversation
simbuerg
force-pushed
the
f/container-support
branch
2 times, most recently
from
August 18, 2020 23:29
d0e8d09 to
1cac450
Compare
simbuerg
force-pushed
the
f/container-support
branch
from
September 1, 2020 16:46
8b5c955 to
aa78152
Compare
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
==========================================
+ Coverage 53.71% 54.34% +0.62%
==========================================
Files 112 124 +12
Lines 6404 7092 +688
Branches 666 730 +64
==========================================
+ Hits 3440 3854 +414
- Misses 2835 3110 +275
+ Partials 129 128 -1
Continue to review full report at Codecov.
|
boehmseb
reviewed
Sep 3, 2020
boehmseb
reviewed
Sep 3, 2020
Removes explicit versions from setup.py (temp)
vulder
requested changes
Sep 23, 2020
vulder
left a comment
Collaborator
There was a problem hiding this comment.
I finish the rest of the review at home later :)
| self.append(model.AddLayer(sources, tgt)) | ||
| return self | ||
|
|
||
| def copy_(self, sources: tp.Iterable[str], tgt: str) -> 'ContainerImage': |
Collaborator
There was a problem hiding this comment.
Why it this method name ending in a _
boehmseb
reviewed
Sep 24, 2020
boehmseb
reviewed
Sep 24, 2020
vulder
requested changes
Sep 24, 2020
This recovers from failed cleanups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support use of OCI Containers in Projects
This PR introduces support for OCI (and Docker) containers in Projects and Experiments. Running an experiment inside an OCI
compliant container removes the need to take care about dependencies on the host-machine and provides stability between system upgrades.
This brings BenchBuild one step closer to reproducability of experiments.
Design
The user has to be concerned with 3 types of container images.
image from. These images need to be able to install and run benchbuild. It is not required to use these, but recommended.
Requirements
buildahhttps://buildah.io/podmanhttps://podman.io/Configuration
Benchbuild uses
buildahto build container images. All images are stored in an isolated container registry. The location of thisregistry can be controlled by Benchbuild's settings. The following settings are the defaults:
There are more options, but these are unused and/or deprecated.
Try it out
The following aliases help during testing. As long as you stay in the same directory as you run benchbuild from, these will always run against benchbuild's registry.
Both tools have access to the same local container registry. Buildah is used for container image construction and Podman is a drop-in replacement for docker (without the daemon).
Example:
In the current state of this PR, you can prepare images that are able to run the selected projects.
This should result in the following images being committed to your container registry. Note that, podman and buildah share
the same registry.
In the completed implementation, benchbuild will spawn the container and execute the experiments on the configured projects.
As a test, you can do this manually for now:
Note: This will re-download static video files, due to a missing feature in the http downloader module. This is not a problem in these tests and will be fixed in the final release. Git-Downloads do not suffer from this.
The above command should yield the same results as a standard benchbuild run command: