Repository navigation
docs: define ASAPPlanner input, output, and workflow - #445
Merged
Merged
Conversation
Selvomega
requested changes
Sep 19, 2026
Contributor
Author
5 tasks
This was referenced Sep 21, 2026
…-names refactor!: align candidate and DAG assembly API names (#456)
Selvomega
approved these changes
Sep 22, 2026
Selvomega
added a commit
that referenced
this pull request
Sep 26, 2026
Brings per-measure FILTER predicates (#466) plus the five main commits it is based on (#445, #455, #426, #460, #461). Conflicts resolved toward main: `ValueOperationAtIngestionTime`, `query_time_nested_sum`, and the unconditional `finalize_exact_accumulator` from #461 replace dev/dqc's older #379 shape; the #455 wording in the architecture docs stands; the moved `accuracy.rs` is dropped in favor of `accuracy/mod.rs`. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Selvomega
added a commit
that referenced
this pull request
Sep 29, 2026
Cherry-pick of the PR #458 merge commit (4dd64e5) onto main. PR #458 was merged into refactor/issue-456-interface-names after that branch had already reached main via #457 and #445, so its content never landed on main. Adds the asap-planner facade crate (#429), the pluggable optimization pass (#430), and the ParsedWorkload boundary type. Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
zzylol
added a commit
that referenced
this pull request
Sep 30, 2026
#445, #470, #472, and #478 each described the Planner output from a different angle. Add an output-layers section that places them in order: candidate space, selected logical plan, and exported logical DAG. Say that PlanOutput is derived from PlanSpace rather than being a second output. Use "candidate" instead of "alternative" throughout input-output-workflow.md. Rebase note: conflicts in docs/design_docs/architecture/input-output-workflow.md with the stack below are resolved to this commit's version of the file, as integration merge e59640f resolved them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
added a commit
that referenced
this pull request
Sep 30, 2026
#445, #470, #472, and #478 each described the Planner output from a different angle. Add an output-layers section that places them in order: candidate space, selected logical plan, and exported logical DAG. Say that PlanOutput is derived from PlanSpace rather than being a second output. Use "candidate" instead of "alternative" throughout input-output-workflow.md. Rebase note: conflicts in docs/design_docs/architecture/input-output-workflow.md with the stack below are resolved to this commit's version of the file, as integration merge e59640f resolved them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Issue #438 shows that the current documentation exposes individual planner stages without first defining the supported end-to-end integration workflow. Callers cannot easily tell which inputs are required, when lifecycle planning is necessary, or whether
PlanSpace, a ranked group, or a materialized DAG is the final output. Related terminology and API-surface ambiguity is tracked in #427, and #428.Before this PR
A caller could discover
search_workload*,cost_sorted,global_selection, and lifecycle APIs independently and reasonably conclude that each was a separate valid end state. For example, a recurring summary could be structurally selected without making clear that this does not establish that maintaining it is cheaper than exact recomputation. Window semantics, summary frameworks, physical layouts, window edges, and physical handoffs were also easy to conflate.After this PR
The design documentation starts from one outer workflow: canonical roots and requirements enter ASAPPlanner, and
PlanSpaceis the canonical logical output. It then explicitly documents:PlanSpace, ranked views, materialized DAGs, and lifecycle-aware outputs;The lifecycle-aware workflow is identified as the recommended path before claiming that maintained summary state is preferable to raw execution. Physical binding, deployment, transitions, and execution remain downstream responsibilities. The document also states that public Rust visibility does not automatically make a type part of the recommended integration surface.
Renames: before vs. after
MemoGroupTargetSubDAGCandidatesRankedGroupRankedTargetSubDAGCandidatesGlobalSelection::materialize(root)GlobalSelection::assemble_selected_dag(root)materialize_with_summary_maintenance_lifecycles(...)assemble_selected_dag_with_summary_maintenance_lifecycles(...)The four Rust API renames are source-breaking: update imports and call sites. They do not change planning behavior or the DAG-root representation.
Remaining names such as
groups(),group_for(),SelectedGroup, andMaterializeSummaryMaintenanceLifecycleErrorare renamed separately in #457 (issue #456), not in this PR. The integration entry-point API is tracked separately in #458 (issue #453).Validation
git diff --checkCloses #438
Related to #427 and #428
Related to ProjectASAP/ASAPQuery-backend#734