Repository navigation
refactor!: align candidate and DAG assembly API names (#456) - #457
Merged
zzylol merged 2 commits intoSep 22, 2026
Merged
Conversation
This was referenced Sep 21, 2026
5 tasks
Selvomega
added a commit
that referenced
this pull request
Sep 29, 2026
Cherry-pick of the PR #458 merge commit (4dd64e5) onto main. PR #458 was merged into refactor/issue-456-interface-names after that branch had already reached main via #457 and #445, so its content never landed on main. Adds the asap-planner facade crate (#429), the pluggable optimization pass (#430), and the ParsedWorkload boundary type. Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes #456. Align the remaining candidate/selection and assembly names with the input/output/workflow design. #453 handles the integration facade separately.
Before this PR
An integration used
space.groups()andselection.groups()for two different concepts, and an assembly failure was namedMaterializeSummaryMaintenanceLifecycleError, suggesting runtime materialization.After this PR
space.target_subdag_candidates()/candidates_for_target(...)expose alternatives.selection.target_selections()returnsTargetSubDAGSelectiondecisions.SummaryMaintenanceLifecycleAssemblyError::AssembleDagdescribes DAG assembly failures.This is a breaking Rust source rename, not a planning behavior change. The migration table is in
docs/develop_docs/target-candidate-api-migration.md. Downstream callers must update these symbols; no compatibility aliases or serialized schema changes.Validation
cargo test --workspacepassed.cargo fmt --allandgit diff --checkpassed.Dependency
Stacked on #445 (
docs/issue-438-planner-contract) because that PR contains the prerequisite names and design. Retarget tomainafter #445 merges. This PR is separate from the #453 API entry-point work.