Skip to content

fix: generate DDSketch quantile-ratio candidates without evidence - #449

Merged
zzylol merged 4 commits into
mainfrom
fix/issue-446-demo-ddsketch-ratio
Sep 21, 2026
Merged

zzylol merged 4 commits into
mainfrom
fix/issue-446-demo-ddsketch-ratio

Conversation

@zzylol

@zzylol zzylol commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Closes #446

Before this PR

quantile_over_time(0.9, data[5m]) / quantile_over_time(0.5, data[5m]) fell back to KeepPreAsap without input-domain evidence. After exposing the candidate, target-aware search removed it before the backend could inspect it.

After this PR

  • The default strategy generates the direct DDSketch ratio candidate without domain evidence.
  • A target-aware PlanSpace retains the candidate with guarantee: None for ASAPQuery-backend to inspect and decide using its own evidence. Other unknown or target-missing candidates remain filtered.
  • Planner automatic global_selection does not choose the uncertified ratio; materialization falls back to exact KeepPreAsap. A ratio certified by complete valid evidence remains automatically selectable.
  • Invalid supplied domains are rejected, including when the other operand has no evidence.
  • The Planner/backend ownership boundary is documented in the library and ratio design docs.

Verification

  • New regression failed before the auto-selection fix and passes after it.
  • cargo fmt --all -- --check
  • cargo test -p asap-aware-mapping
  • cargo test -p asap-integration-tests
  • cargo clippy -p asap-aware-mapping -p asap-integration-tests --all-targets -- -D warnings

@zzylol zzylol changed the title fix: expose uncertified DDSketch ratios in v1 demo fix: generate DDSketch quantile-ratio candidates without evidence Sep 21, 2026
@zzylol
zzylol merged commit f5f4e53 into main Sep 21, 2026
4 checks passed
@zzylol
zzylol deleted the fix/issue-446-demo-ddsketch-ratio branch September 21, 2026 18:44
zzylol added a commit that referenced this pull request Sep 21, 2026
* refactor!: prune redundant planning enums and operator tags

* build: unpin asap_sketchlib rev (#451)

Downstream repos depend on Sketchlib by bare git URL; Cargo treats ?rev=
as a distinct source, so consumers got two copies of asap_sketchlib.
Cargo.lock keeps builds reproducible.

Closes #450

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

* fix: generate DDSketch quantile-ratio candidates without evidence (#449)

Closes #446

* refactor!: clarify planner realization, schema, and handoff APIs (#448)

---------

Co-authored-by: Milind Srivastava <milindsrivastava1997@users.noreply.github.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify DDSketch quantile-ratio planning for the v1 demo

1 participant