Repository navigation
fix: generate DDSketch quantile-ratio candidates without evidence - #449
Merged
Merged
Conversation
zzylol
added a commit
that referenced
this pull request
Sep 21, 2026
* refactor!: prune redundant planning enums and operator tags * build: unpin asap_sketchlib rev (#451) Downstream repos depend on Sketchlib by bare git URL; Cargo treats ?rev= as a distinct source, so consumers got two copies of asap_sketchlib. Cargo.lock keeps builds reproducible. Closes #450 Co-authored-by: Claude Opus 5 <noreply@anthropic.com> * fix: generate DDSketch quantile-ratio candidates without evidence (#449) Closes #446 * refactor!: clarify planner realization, schema, and handoff APIs (#448) --------- Co-authored-by: Milind Srivastava <milindsrivastava1997@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #446
Before this PR
quantile_over_time(0.9, data[5m]) / quantile_over_time(0.5, data[5m])fell back toKeepPreAsapwithout input-domain evidence. After exposing the candidate, target-aware search removed it before the backend could inspect it.After this PR
PlanSpaceretains the candidate withguarantee: Nonefor ASAPQuery-backend to inspect and decide using its own evidence. Other unknown or target-missing candidates remain filtered.global_selectiondoes not choose the uncertified ratio; materialization falls back to exactKeepPreAsap. A ratio certified by complete valid evidence remains automatically selectable.Verification
cargo fmt --all -- --checkcargo test -p asap-aware-mappingcargo test -p asap-integration-testscargo clippy -p asap-aware-mapping -p asap-integration-tests --all-targets -- -D warnings