Repository navigation
chore: unpin asap_sketchlib rev - #451
Merged
Merged
Conversation
2 tasks
milindsrivastava1997
force-pushed
the
450-unpin-asap_sketchlib-rev-in-workspace-cargotoml
branch
from
September 18, 2026 22:02
49e702d to
aab3074
Compare
Downstream repos depend on Sketchlib by bare git URL; Cargo treats ?rev= as a distinct source, so consumers got two copies of asap_sketchlib. Cargo.lock keeps builds reproducible. Closes #450 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
milindsrivastava1997
force-pushed
the
450-unpin-asap_sketchlib-rev-in-workspace-cargotoml
branch
from
September 18, 2026 22:02
aab3074 to
2ebb79c
Compare
zzylol
approved these changes
Sep 21, 2026
zzylol
deleted the
450-unpin-asap_sketchlib-rev-in-workspace-cargotoml
branch
September 21, 2026 13:23
zzylol
added a commit
that referenced
this pull request
Sep 21, 2026
* refactor!: prune redundant planning enums and operator tags * build: unpin asap_sketchlib rev (#451) Downstream repos depend on Sketchlib by bare git URL; Cargo treats ?rev= as a distinct source, so consumers got two copies of asap_sketchlib. Cargo.lock keeps builds reproducible. Closes #450 Co-authored-by: Claude Opus 5 <noreply@anthropic.com> * fix: generate DDSketch quantile-ratio candidates without evidence (#449) Closes #446 * refactor!: clarify planner realization, schema, and handoff APIs (#448) --------- Co-authored-by: Milind Srivastava <milindsrivastava1997@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #450.
Why: Downstream repos (ASAPQuery-backend, ASAPCollector) depend on Sketchlib by bare git URL. Cargo treats
?rev=…as a different source, so consumers get two copies ofasap_sketchliband type mismatches once Sketchlib types cross the Planner boundary.Before this PR
Lock source:
git+…/asap_sketchlib?rev=da3635a8…#da3635a8— distinct from consumers'git+…/asap_sketchlib#….After this PR
Lock source:
git+…/asap_sketchlib#932ab4af(current Sketchlibmain), same source identity as consumers.Cargo.lockkeeps builds reproducible.How: Edited the workspace dependency, ran
cargo update -p asap_sketchlib. No code changes were needed against Sketchlibmain:cargo test --workspace --lockedandcargo clippy --workspace --all-targetspass cleanly.🤖 Generated with Claude Code