Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 5.0.x_dev #117 +/- ##
=============================================
+ Coverage 63.66% 64.26% +0.60%
=============================================
Files 74 73 -1
Lines 9077 9132 +55
=============================================
+ Hits 5779 5869 +90
+ Misses 3298 3263 -35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
seb5g
left a comment
There was a problem hiding this comment.
why doing things differently on main menu and submenu can we not just consider on only menu argument/dict...
Also by introducing this I guess the setup_menu in custom_app start to be superfluous?
- Adding menus and toolbars -Removing get_action path
There was no reason, I did not want first to touch self._menu but using arg/dict is much better and smoother.
I agree, in fact I started to look at it by considering that the ConfigManager could inherit from the ActionManager and build its own QMenu. One can think of standardized QActions for examples, New/Edit/Duplicate/Load/Delete/Open Config folder/ ...). |
seb5g
left a comment
There was a problem hiding this comment.
it looks quite nice and neat!
apply add_widget also to toolbar specified using str (missing in #117)
Context:
Action manager is very useful and versatile to easily manage QActions and add them to menu/toolbar.
However, it does not necessarily handle well submenus for now making the construction of more complex QMenu quite cumbersome.
In this PR:
We extend Action Manager capabilities by adding the _submenus dict.
This permits to easily store new submenus, attach them to menus and to benefit from the ActionManager methods function.
A little example can be found in examples/action_manager_nested_menu.py
action_manager_menu.mp4