Skip to content
This repository was archived by the owner on Nov 6, 2025. It is now read-only.

apply add_widget also to toolbar specified using str (missing in #117) - #120

Merged
seb5g merged 1 commit into
5.0.x_devfrom
patch/action_manager
Oct 28, 2025
Merged

seb5g merged 1 commit into
5.0.x_devfrom
patch/action_manager

Conversation

@seb5g

@seb5g seb5g commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@seb5g

seb5g commented Oct 28, 2025

Copy link
Copy Markdown
Contributor Author

@Ashwolaa your PR #117 was missing the toolbar mechanism for add_widget. This solves this

@Ashwolaa

Copy link
Copy Markdown
Contributor

nice catch

@seb5g
seb5g merged commit 3a1a81b into 5.0.x_dev Oct 28, 2025
15 of 24 checks passed
@codecov

codecov Bot commented Oct 28, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.24%. Comparing base (b25a9b4) to head (075e0b0).
⚠️ Report is 2 commits behind head on 5.0.x_dev.

Files with missing lines Patch % Lines
src/pymodaq_gui/managers/action_manager.py 44.44% 5 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           5.0.x_dev     #120      +/-   ##
=============================================
- Coverage      64.26%   64.24%   -0.03%     
=============================================
  Files             73       73              
  Lines           9132     9137       +5     
=============================================
+ Hits            5869     5870       +1     
- Misses          3263     3267       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@seb5g
seb5g deleted the patch/action_manager branch October 28, 2025 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants