refactor: package code organization wave 13 - #2367
Conversation
…acts-ops Behavior-preserving package organization after wave 12: - app/api: planning, dev-server, mission-interview, models-usage, task-steer, ai-summarize (legacy re-exports kept) - rename remaining-ops-7 → task-store/task-artifacts-ops.ts - legacy.ts shrinks below the 2000-line cap (~3342 → ~1408)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR reorganizes package code while keeping existing public API paths stable. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (3): Last reviewed commit: "merge: wave12 into wave13 after main boo..." | Re-trigger Greptile |
## Summary Wave 14 of package code organization (stacks on #2367 / wave 13). ### Peels | New module | Parent | |---|---| | `types/task-review.ts` | task review + PR review surface types | | `types/documents-artifacts.ts` | documents, artifacts, review-artifact helpers, goal citations | | `task-store/workflow-task-create-ops.ts` | rename of `remaining-ops-4` | | `task-store/task-mutation-ops.ts` | rename of `remaining-ops-2` | Public paths stay stable via `types.ts` / `store.ts` re-exports. ### LOC - `types.ts` ~6264 → ~5871 ### Shims - `types.ts` → peels above (delete-when: consumers import domain modules) - `remaining-ops-4` → `workflow-task-create-ops` (rename complete) - `remaining-ops-2` → `task-mutation-ops` (rename complete) Only `remaining-ops-1.ts` remains of the numbered ops series. ## Test plan - [x] `@fusion/core` typecheck - [x] `review-artifacts` unit tests - [x] `pnpm check:line-count` (baseline updated) - [ ] CI merge gate <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Split task review, document, artifact, and goal-citation type definitions into dedicated shared modules. - Updated task-operation wiring to use the newer task-create/mutation operation surfaces (no API changes intended). - **Documentation** - Corrected inline references and refreshed module headers to match the current task-operation structure and domain naming. - **Tests** - Updated a test import to point to the current duplicate-auto-archive backend implementation source. - **Chores** - Refreshed line-count baseline values to reflect the latest code layout. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary
Wave 13 of package code organization (stacks on #2362 / wave 12).
Peels
app/api/planning.tsapp/api/dev-server.tsapp/api/mission-interview.tsapp/api/models-usage.tsapp/api/task-steer.tsapp/api/ai-summarize.tstask-store/task-artifacts-ops.tsremaining-ops-7Public paths stay stable via
legacy.tsre-exports (app/api.ts→legacy).LOC
legacy.ts~3342 → ~1408 (under the 2000-line hard cap; removed from grandfather baseline)Shims
legacy.ts→ peels above (delete-when: dashboard imports domain modules)remaining-ops-7→task-artifacts-ops(rename complete)Test plan
pnpm check:line-count(baseline updated)