refactor: package code organization wave 14 - #2391
Conversation
…, task-id-integrity Behavior-preserving package organization after wave 11: - app/api: git, workspace-files, provider-status, github/gitlab-import, run-audit, task-diff, agent-import-generation (legacy re-exports kept) - types/run-audit.ts + types/planner-intervention.ts peels from types.ts - rename remaining-ops-5 → task-store/task-id-integrity.ts - Ratchet legacy.ts line-count ceiling (~5665 → ~3339)
Prefer ApiRequestError.status === 404 over case-sensitive message matching when agent children are missing, with a case-insensitive not-found fallback.
…acts-ops Behavior-preserving package organization after wave 12: - app/api: planning, dev-server, mission-interview, models-usage, task-steer, ai-summarize (legacy re-exports kept) - rename remaining-ops-7 → task-store/task-artifacts-ops.ts - legacy.ts shrinks below the 2000-line cap (~3342 → ~1408)
Behavior-preserving package organization after wave 13: - types/task-review.ts — review/PR-review surface types - types/documents-artifacts.ts — documents, artifacts, goal citations - rename remaining-ops-4 → task-store/workflow-task-create-ops.ts - rename remaining-ops-2 → task-store/task-mutation-ops.ts - Ratchet types.ts line-count ceiling (~6264 → ~5871)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughChangesThe PR extracts task-review and documents-artifacts contracts from the core types barrel into dedicated modules while preserving re-exports. It also rewires task-store imports to renamed operation modules, updates related comments and tests, and regenerates line-count baselines. Core contracts and module wiring
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR reorganizes core types and task-store operations into clearer domain modules. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "merge: origin/main into wave14; resolve ..." | Re-trigger Greptile |
| "packages/engine/src/executor.ts": 20352, | ||
| "packages/engine/src/merger-ai.ts": 2445, | ||
| "packages/engine/src/merger.ts": 11244, | ||
| "packages/engine/src/pi.ts": 2847, |
There was a problem hiding this comment.
Unrelated Growth Enters Baseline
This raises executor.ts from 20,076 to 20,352 even though that file is unchanged in this PR. Future audits now accept those 276 unrelated lines, so later changes can exceed the previously recorded limit without being reported; several other untouched files are raised in the same update.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Keep workflow-task-create-ops import after remaining-ops-4 rename. Regenerate line-count baseline against the merged tree.
Summary
Wave 14 of package code organization (stacks on #2367 / wave 13).
Peels
types/task-review.tstypes/documents-artifacts.tstask-store/workflow-task-create-ops.tsremaining-ops-4task-store/task-mutation-ops.tsremaining-ops-2Public paths stay stable via
types.ts/store.tsre-exports.LOC
types.ts~6264 → ~5871Shims
types.ts→ peels above (delete-when: consumers import domain modules)remaining-ops-4→workflow-task-create-ops(rename complete)remaining-ops-2→task-mutation-ops(rename complete)Only
remaining-ops-1.tsremains of the numbered ops series.Test plan
@fusion/coretypecheckreview-artifactsunit testspnpm check:line-count(baseline updated)Summary by CodeRabbit