feat: 팀 프로젝트 대시보드 위젯 구현 - #48
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthrough진행률 요약 계산을 엔터티 모델로 이동하고 워크스페이스별 목업 데이터 해석을 확장했습니다. Changes대시보드 진행률·업무 요약 위젯
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Dashboard
participant WidgetCatalog
participant OverallProgress
participant WorkSummary
participant MockTaskProvider
participant WorkspaceMemberProvider
Dashboard->>WidgetCatalog: workspaceId로 위젯 렌더링 요청
WidgetCatalog->>OverallProgress: workspaceId 전달
WidgetCatalog->>WorkSummary: workspaceId 전달
OverallProgress->>MockTaskProvider: 태스크 조회
WorkSummary->>MockTaskProvider: 태스크 조회
WorkSummary->>WorkspaceMemberProvider: 멤버 조회
OverallProgress-->>Dashboard: 진행률 카드 렌더링
WorkSummary-->>Dashboard: 업무 요약 카드 렌더링
Possibly related issues
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/entities/progress-chart/model/create-progress-chart-summary.ts`:
- Around line 24-30: Update toPercentage so nonzero ratios retain one decimal
place, matching the progress card’s expected 46.7% result for 7/15; preserve the
existing zero-total return of 0 and replace integer rounding with one-decimal
precision.
In `@src/entities/workspace-member/model/mock-workspace-members.ts`:
- Around line 179-181: Update getMockWorkspaceMembersByWorkspaceId to fall back
to the team-workspace identifier when the supplied workspace UUID has no entry
in workspaceMemberAliasById, and update its callers to pass team-workspace for
the WorkSummary member lookup. Preserve alias resolution for known workspace
IDs.
In `@src/views/dashboard/config/widget-catalog.tsx`:
- Around line 70-81: team-project에서 함께 허용되는 위젯의 기본 레이아웃 좌표가 서로 겹치지 않도록 widget
catalog와 template-widgets의 레이아웃을 재계산하세요. 특히 work-summary와 my-tasks,
overall-progress와 calendar의 충돌을 제거하고 DashboardView가 addWidget에 전달하는 모든 기본 사각형이
비중첩 상태가 되게 하세요. team-project 허용 목록과 카탈로그 레이아웃을 검증하는 통합 테스트도 추가하세요.
In `@src/widgets/team-project/dashboard-work-summary/ui/WorkSummary.tsx`:
- Around line 30-31: Update WorkSummary to reuse the entity’s
createProgressChartSummary result for card values, using summary.totalTaskCount,
summary.doneTaskCount, and summary.inProgressTaskCount instead of local
countByStatus aggregation. Remove the unused completionRate calculation and the
countByStatus helper, while preserving the existing rendering structure.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 6f88209f-32d0-40a1-8f7b-6f4cd60eeab6
📒 Files selected for processing (11)
src/entities/progress-chart/index.tssrc/entities/progress-chart/model/create-progress-chart-summary.tssrc/entities/task/model/mock-tasks-by-workspace.tssrc/entities/workspace-member/model/mock-workspace-members.tssrc/features/manage-progress-chart/model/progress-chart.tssrc/views/dashboard/config/template-widgets.tssrc/views/dashboard/config/widget-catalog.tsxsrc/widgets/team-project/dashboard-overall-progress/index.tssrc/widgets/team-project/dashboard-overall-progress/ui/OverallProgress.tsxsrc/widgets/team-project/dashboard-work-summary/index.tssrc/widgets/team-project/dashboard-work-summary/ui/WorkSummary.tsx
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/views/dashboard/config/template-widgets.ts`:
- Around line 37-38: Update the overlapping layout coordinates in
TEMPLATE_WIDGETS, specifically the side-project sprint-summary, my-tasks, and
velocity entries, so all widgets occupy non-overlapping areas. Preserve the
existing validateTemplateWidgetLayouts call for non-production environments
after correcting the catalog coordinates.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 625264bd-89a2-45a5-9f08-6f66b8acf38d
📒 Files selected for processing (7)
src/entities/progress-chart/model/create-progress-chart-summary.tssrc/entities/workspace-member/model/mock-workspace-members.tssrc/views/dashboard/config/template-widgets.tssrc/views/dashboard/config/validate-template-widget-layouts.tssrc/views/dashboard/config/widget-catalog.tsxsrc/widgets/team-project/dashboard-overall-progress/ui/OverallProgress.tsxsrc/widgets/team-project/dashboard-work-summary/ui/WorkSummary.tsx
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/views/dashboard/config/widget-catalog.tsx`:
- Line 29: Resolve the remaining default layout collisions in the shared widget
catalog, including the entries around my-tasks, recent-notices, recent-notes,
recent-resources, work-summary, overall-progress, calendar, and work-schedule.
Recalculate coordinates so every widget is non-overlapping across the
team-project and store-operation templates, or separate layouts per template;
add validation tests covering these layouts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 9b592246-9b67-45da-81d1-9e8a1d0f8e60
📒 Files selected for processing (1)
src/views/dashboard/config/widget-catalog.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
작업 내용
업무 요약,전체 진행률위젯을 구현했습니다.작업 결과
업무 요약,전체 진행률위젯을 추가해 확인할 수 있습니다.업무 요약은 전체 업무, 완료된 업무, 진행중, 팀 멤버 수를 카드 형태로 표시합니다.전체 진행률은 완료 개수와 전체 개수, 진행률 바를 피그마에 가깝게 표시합니다.변경 사항
Added
src/widgets/team-project/dashboard-work-summarysrc/widgets/team-project/dashboard-overall-progresssrc/entities/progress-chart/model/create-progress-chart-summary.tsChanged
업무 요약,전체 진행률위젯을 추가했습니다.Fixed
실행화면
테스트
리뷰 체크리스트
feature/*->develop, 배포 시develop또는release/*->main)Type/#issue-number/description형식을 따릅니다.console.log, 주석, 임시 코드를 제거했습니다.리뷰 요청사항
업무 요약,전체 진행률위젯의 피그마 반영 정도를 중점적으로 봐주시면 좋겠습니다.관련 이슈
Closes #45
Summary by CodeRabbit