[Feat] 진행률 차트 페이지 구현 - #40
Merged
Merged
Conversation
📝 WalkthroughWalkthrough워크스페이스별 진행률 차트 페이지를 추가했습니다. 작업 데이터에서 진행률 요약을 계산하고, 숫자 요약·진행률·담당자·상태 차트를 렌더링하며, 새 라우트에서 workspaceId를 전달합니다. Changes진행률 차트 기능
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant WorkspaceRoute
participant ProgressChartPage
participant ProgressChartView
participant getMockTasksByWorkspaceId
participant createProgressChartSummary
WorkspaceRoute->>ProgressChartPage: workspaceId 전달
ProgressChartPage->>ProgressChartView: workspaceId 전달
ProgressChartView->>getMockTasksByWorkspaceId: workspaceId로 mock 작업 조회
getMockTasksByWorkspaceId-->>ProgressChartView: Task[] 반환
ProgressChartView->>createProgressChartSummary: 작업 목록 전달
createProgressChartSummary-->>ProgressChartView: ProgressChartSummary 반환
ProgressChartView-->>WorkspaceRoute: 차트 UI 렌더링
Possibly related issues
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/features/manage-progress-chart/ui/ProgressChartView.tsx`:
- Around line 72-122: AssigneeBarChartCard의 막대 높이가 데이터 최댓값 기준으로 정규화되어 고정
Y축(0~8)과 불일치합니다. gridValues의 최댓값을 기준값으로 사용하도록 높이 계산을 변경하고, item.count가 해당 축 최댓값을
초과할 때는 차트 영역을 넘지 않도록 제한하세요.
- Line 1: Remove the `'use client'` directive from `ProgressChartView` so it is
treated as a server component, since its mock data aggregation and rendering are
fully synchronous and static.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 77fffd45-06fe-41b4-9c29-2997efbd64cf
📒 Files selected for processing (8)
src/app/workspaces/[workspaceId]/progress-chart/page.tsxsrc/entities/progress-chart/index.tssrc/entities/progress-chart/model/progress-chart.types.tssrc/features/manage-progress-chart/index.tssrc/features/manage-progress-chart/model/progress-chart.tssrc/features/manage-progress-chart/ui/ProgressChartView.tsxsrc/views/progress-chart/index.tssrc/views/progress-chart/ui/ProgressChartPage.tsx
seongjinss555
approved these changes
Jul 10, 2026
seongjinss555
left a comment
Contributor
There was a problem hiding this comment.
코드레빗과 리뷰 된 것들 확인해봤습니다. 수정사항 완료 되시면 머지해주세요!
This was referenced Jul 13, 2026
Merged
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
작업 내용
app / views / features / entities레이어를 분리했습니다.작업 결과
/workspaces/test/progress-chart경로에서 진행률 차트 페이지에 진입할 수 있습니다.변경 사항
Added
src/app/workspaces/[workspaceId]/progress-chart/page.tsxsrc/views/progress-chart/index.tssrc/views/progress-chart/ui/ProgressChartPage.tsxsrc/features/manage-progress-chart/index.tssrc/features/manage-progress-chart/model/progress-chart.tssrc/features/manage-progress-chart/ui/ProgressChartView.tsxsrc/entities/progress-chart/index.tssrc/entities/progress-chart/model/progress-chart.types.tsChanged
Fixed
실행화면
테스트
리뷰 체크리스트
feature/*->develop, 배포 시develop또는release/*->main)Type/#issue-number/description형식을 따릅니다.console.log, 주석, 임시 코드를 제거했습니다.리뷰 요청사항
관련 이슈
Closes #38
Summary by CodeRabbit