design:워크스페이스 모듈 로딩 스켈레톤(#83) - #84
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 48 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough워크스페이스 모듈별 공통 스켈레톤 컴포넌트를 추가하고, 각 라우트의 Changes워크스페이스 모듈 로딩 스켈레톤
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant WorkspaceRoute
participant Loading
participant WorkspacePageSkeleton
WorkspaceRoute->>Loading: 로딩 경계 진입
Loading->>WorkspacePageSkeleton: variant 전달
WorkspacePageSkeleton-->>Loading: 페이지별 스켈레톤 반환
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/shared/ui/skeleton.tsx`:
- Around line 7-10: Update the Skeleton component’s className composition to use
the project’s existing cn utility or tailwind-merge instead of a template
literal, so caller-provided rounded-* classes such as rounded-full or
rounded-2xl override the default rounded-lg without conflicting classes.
In `@src/widgets/workspace-page-skeleton/ui/WorkspacePageSkeleton.tsx`:
- Around line 146-147: Update the height-related arbitrary Tailwind values in
WorkspacePageSkeleton so every calc() subtraction includes spaces around the
operator, represented with underscores for Tailwind syntax. Apply this to both
min-h and h declarations while preserving their existing viewport calculations
and sizing behavior.
- Around line 127-135: Update the calendar grid in WorkspacePageSkeleton so the
container uses a 1px gap with the existing border-color background, and each
cell uses a white background. Remove the cell border classes, including
border-r, border-b, and last:border-r-0, while preserving the 7-column, 42-cell
layout and skeleton content.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 7b1b3c4f-33fc-4288-896e-68dd03828765
📒 Files selected for processing (15)
src/app/workspaces/[workspaceId]/calendar/loading.tsxsrc/app/workspaces/[workspaceId]/chat/loading.tsxsrc/app/workspaces/[workspaceId]/dashboard/loading.tsxsrc/app/workspaces/[workspaceId]/files/loading.tsxsrc/app/workspaces/[workspaceId]/meeting-notes/loading.tsxsrc/app/workspaces/[workspaceId]/notices/loading.tsxsrc/app/workspaces/[workspaceId]/notifications/loading.tsxsrc/app/workspaces/[workspaceId]/progress-chart/loading.tsxsrc/app/workspaces/[workspaceId]/project-management/loading.tsxsrc/app/workspaces/[workspaceId]/settings/loading.tsxsrc/app/workspaces/[workspaceId]/sprint-board/loading.tsxsrc/app/workspaces/[workspaceId]/work-schedule/loading.tsxsrc/shared/ui/skeleton.tsxsrc/widgets/workspace-page-skeleton/index.tssrc/widgets/workspace-page-skeleton/ui/WorkspacePageSkeleton.tsx
Pull Request
작업 내용
loading.tsx경계로 본문 영역만 로딩 상태로 전환합니다.작업 결과
변경 사항
Added
SkeletonUI 컴포넌트WorkspacePageSkeleton위젯 및 화면 유형별 변형loading.tsxChanged
Fixed
실행화면
테스트
npm run lintnpm run typecheckgit diff --check리뷰 체크리스트
develop)console.log, 임시 코드를 추가하지 않았습니다.리뷰 요청사항
관련 이슈
Closes #83
Summary by CodeRabbit