Repository navigation
fix(cli): finalize macOS signatures and verify release artifacts - #1673
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
# Conflicts: # PLANS.md
luokerenx4
marked this pull request as ready for review
September 30, 2026 18:44
This was referenced Sep 30, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.94.1 macOS CLI can contain an invalid embedded signature even when its published SHA-256 matches. Bun 1.4.2 fixes the ARM64 tail-page hash, but the x64 compiler still carries stale signature coverage. Finalize both macOS executables with system ad-hoc codesign before generating payload hashes and reject invalid final archives before channel publication. Related: #1670.
Validation:
Mac acceptance: download the matching architecture artifact for this PR head, verify the .sha256 sidecar, unpack into a fresh temporary directory, run codesign --verify --strict --verbose=2 on bin/openalice and run --version. Use the checked-out install script with --archive, --sha256, --install-dir , --no-modify-path and --yes, plus a separate OPENALICE_HOME for startup/PTY checks. Keep the existing installation/home intact. Do not disable Gatekeeper, change TCC permissions, or re-sign the candidate locally.
Merge to dev is authorized after conflict resolution and exact-head checks. No release publication or changes to PR #1672.
Original implementation head:
1759efbc4a43df45fad1d50e2a8377b1c90b9b5b.Original-head CI evidence (historical):
Dev PR Clean Build: passed workflow contracts and complete workspace build.
CLI artifact acceptance: All four jobs passed: Linux x64, native macOS ARM64, native macOS Intel x64, and final verification of their preserved archives on Linux.
ARM64 Mac artifact:
cli-candidate-darwin-arm64-1759efbc4a43df45fad1d50e2a8377b1c90b9b5b, expires October 7. Contains the archive, sidecar and report. Native codesign strict verification, static full coverage, compiled recovery, identity upgrade and dual PTYs passed.ARM64 tar SHA-256:
510792b4f8574ac63769fa9951c4ea51f549a35af3f1a1d385e1fa3660f182b2; contentIdentitya727492be28b21d1.Intel Mac artifact:
cli-candidate-darwin-x64-1759efbc4a43df45fad1d50e2a8377b1c90b9b5b, expires October 7. Native strict signature verification, retained runtime flags/entitlements, recovery, identity upgrade and dual PTYs passed.Intel tar SHA-256:
1a92f37065fea9c6774600d2570dad51639e12772099aab5569e7fcd5d276e13; contentIdentityaddd346781fb2cfd.Both Mac artifacts passed the final Linux extraction/file/manifest/full code-page signature gate. This is actual native runner evidence, not macOS 27.0.1 user-device acceptance.
Windows x64 and ARM64 cross-compilation with Bun 1.4.2 and final archive verification also passed in isolated temporary homes. Native Windows execution was not attempted.
Latest-dev synchronization:
b61658122c9e25ef7ec0fc2d295c3c18b7ad10ecwithout rewriting history. The sole conflict was PLANS.md; all current task entries and updated test-plan descriptions are retained.4b8f25d6b7d96cf9e3cb5f8a5135470f0c5d11f8.80aa9cc30961586cff35e56caa11de4299f414a5423c5dfd1dd45982ee7b0787, contentIdentityc1b7923c325e4167.095d570816bb4ba9d190cd8cb2e1479df7d114ce59a5778d62b369b61dd4603c, contentIdentity5e63fd87d4ac7eaf.