Repository navigation
test: map bounded startup and lifecycle evidence - #1677
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Map existing assertions for startup → selected Project → running → exit/recovery. The initial eight requirement rows are followed by a bounded
runtime-readyrow and independent safety evidence: concurrent Default writers, stale-heartbeat authority, PID reuse, forced takeover and capped recovery/reset. Add the realisKeyReleasefunction to the incomplete Supervisor mock so its existing cleanup follows #1669's input contract. No behavior assertion removed, runtime change, spec move, owner/lane reassignment or critical-gate narrowing in this PR.Base dev
1a8bec87includes #1669/#1673/#1676. Runtime zombie semantics are fixed separately in Draft #1678. Both PRs remain independently reviewable; Guardian selection on unmodified dev still needs that fix.Effect
Thirteen existing files acquire bounded mappings. File/owner/lane/area tuples and command inventory compare identical. Multiple groups reference the same file without duplicate execution. Startup + Guardian intersects on only the shared CLI-command file; this omits core/lock/process evidence. Run affected protocols independently. Desktop + desktop-ipc still selects one shared IPC file.
Inspected Default, CLI core/presentation, lock, Dock/tray, child shutdown and relay races contain distinct behavior/preconditions or evidence layers. No same-layer identical claim was demonstrated, so no tests deleted. The plan contains the comparison table. Native/platform gaps remain explicit.
Verification
Commands:
pnpm test:select --scenario startup-project-selection,desktop-lifecycle;pnpm test:select --contract guardian-process; append--list --explainfor dry runs. Terminal input/render changes additionally require explicit--path packages/cli/src/supervisor-tui.pty.spec.tsor the owner suite. Static imports and bounded groups do not replace that terminal surface, native Electron/SSH, installed binaries, real services/ports or cross-platform acceptance.No merge or release.
Final-head CI
Head
ca454506ff0de994b7e4333c8f1460e149a987d0: Dev PR Clean Build 36775256152 completed successfully. Workflow contracts, whole critical gate, receipt upload and complete workspace build all passed.critical-local-receiptartifact ID11125577077is confirmed associated with this exact head. Full-suite/native limitations above remain explicit. PR remains Draft.