Fix the verified bugs from the review - #881
Merged
Merged
Conversation
Eleven fixes, each described in the pull request: the attached viewer's menu, quoted PATH entries on .NET Framework, file mode never exiting under a tray, F# backticked member names, an empty entry point hanging the patcher, tabs lost copying a side, Linux shortcuts following key position, a session scoped applier mutex on Unix, killing by a stale PID, the render loop taking the session lock every frame, and a wire accept checking for a conflict outside the lock.
SimonCropp
added a commit
that referenced
this pull request
Sep 23, 2026
Every item that was unverified, checked on c37bf9e: all of them hold, and none was fixed by #878, #881 or #884. Each now says whether it was reproduced, verified by reading, or needs a platform this machine lacks, with the current lines, the repro test names, and where the suggested fix turned out wrong or incomplete. An attached "Accept all in <solution>" deleting verified files whose snapshots were not written moves to Data loss. The repro tests are on a local branch, review-repros, rather than here: each fails until its item is fixed.
SimonCropp
added a commit
that referenced
this pull request
Sep 23, 2026
…885) * Make the Linux viewer draw frames, read input and wait between them raylib 6.0's CMake reads every SUPPORT_ flag in config.h into an option that defaults to ON, including the ones config.h sets to 0, and CUSTOMIZE_BUILD skips config.h's own values. So SUPPORT_CUSTOM_FRAME_CONTROL was on, and EndDrawing never swapped a frame onto the screen, never polled input and never waited for the next frame: the Linux window stayed blank and ignored every key and click while the loop spun. SUPPORT_BUSY_WAIT_LOOP was on the same way, and would have spun through the whole of every frame's wait once there was one. Switch both off, with every other flag config.h defaults to 0, and turn off SUPPORT_SCREEN_CAPTURE, whose F12 handler becomes reachable once input is read. PixelTests.PresentWaitsForTheNextFrame times sixty presents against the renderer the Ubuntu job builds. The pixel snapshots could never have noticed: a capture draws into a texture and never reaches EndDrawing. * Record what checking the review's unverified items found Every item that was unverified, checked on c37bf9e: all of them hold, and none was fixed by #878, #881 or #884. Each now says whether it was reproduced, verified by reading, or needs a platform this machine lacks, with the current lines, the repro test names, and where the suggested fix turned out wrong or incomplete. An attached "Accept all in <solution>" deleting verified files whose snapshots were not written moves to Data loss. The repro tests are on a local branch, review-repros, rather than here: each fails until its item is fixed. * Rebuild native renderer binaries (#886) Co-authored-by: SimonCropp <122666+SimonCropp@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: SimonCropp <122666+SimonCropp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verified bugs from the review in todo.md, one fix each.
DiffEngineViewer left rightnever exited while the tray ran. Closing hid the window in file mode too, where nothing can show it again. Hiding is now for inline mode only.The Linux key change is in native/src/deview.cpp, so this push runs build-native, which should open its own PR with the rebuilt binaries.
Run locally on Windows, all passing: DiffEngine.Tests 703, DiffEngineViewer.Tests 359, DiffEngineTray.Tests 246, and a Release build of the solution.