Skip to content

Rebuild native renderer binaries - #886

Merged
SimonCropp merged 1 commit into
fix-linux-frame-controlfrom
native-binaries-fix-linux-frame-control
Sep 23, 2026
Merged

SimonCropp merged 1 commit into
fix-linux-frame-controlfrom
native-binaries-fix-linux-frame-control

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Rebuilt diffengine_viewer from native/ for the four RIDs that load one.
Windows is not among them: that head renders with WinForms.

Produced by the build-native workflow from 474b945.

@SimonCropp
SimonCropp merged commit fbdf6b2 into fix-linux-frame-control Sep 23, 2026
1 check passed
@SimonCropp
SimonCropp deleted the native-binaries-fix-linux-frame-control branch September 23, 2026 03:53
SimonCropp added a commit that referenced this pull request Sep 23, 2026
…885)

* Make the Linux viewer draw frames, read input and wait between them

raylib 6.0's CMake reads every SUPPORT_ flag in config.h into an option that
defaults to ON, including the ones config.h sets to 0, and CUSTOMIZE_BUILD
skips config.h's own values. So SUPPORT_CUSTOM_FRAME_CONTROL was on, and
EndDrawing never swapped a frame onto the screen, never polled input and never
waited for the next frame: the Linux window stayed blank and ignored every key
and click while the loop spun. SUPPORT_BUSY_WAIT_LOOP was on the same way, and
would have spun through the whole of every frame's wait once there was one.

Switch both off, with every other flag config.h defaults to 0, and turn off
SUPPORT_SCREEN_CAPTURE, whose F12 handler becomes reachable once input is read.

PixelTests.PresentWaitsForTheNextFrame times sixty presents against the
renderer the Ubuntu job builds. The pixel snapshots could never have noticed:
a capture draws into a texture and never reaches EndDrawing.

* Record what checking the review's unverified items found

Every item that was unverified, checked on c37bf9e: all of them hold, and
none was fixed by #878, #881 or #884. Each now says whether it was reproduced,
verified by reading, or needs a platform this machine lacks, with the current
lines, the repro test names, and where the suggested fix turned out wrong or
incomplete.

An attached "Accept all in <solution>" deleting verified files whose snapshots
were not written moves to Data loss. The repro tests are on a local branch,
review-repros, rather than here: each fails until its item is fixed.

* Rebuild native renderer binaries (#886)

Co-authored-by: SimonCropp <122666+SimonCropp@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: SimonCropp <122666+SimonCropp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant