Fix correctness and perf issues in compare, recording, naming and checks#1767
Merged
SimonCropp merged 2 commits intoJul 5, 2026
Conversation
- StreamComparer: compare both streams' read counts and return NotEqual on a
length difference, closing a silent false-pass for non-seekable/empty
received streams
- Callbacks: await every registered OnFirstVerify/OnDelete/OnVerifyMismatch
handler via GetInvocationList instead of only the last (static and instance)
- Recording.TryStop: snapshot the items then Clear and Pause the shared State,
so a stop consumed inside the engine's async flow is observable to the test
(no re-appending on a second verify, IsRecording reflects it)
- Recording: Disposable/NamedDisposable use TryPause so disposing after an
explicit Stop is a no-op instead of throwing
- Recording.IgnoreNames: copy-on-write HashSet read via Volatile.Read, so
IsIgnored on Recording.Add cannot race a concurrent mutation
- MatchingFileFinder: account for a trailing separator on the directory so
UseDirectory("snapshots/") still finds verified files and cleans received
- InnerVerifyChecks: look for .gitignore (was .gitIgnore), so the check runs on
case-sensitive file systems; message updated to match
- Naming: pass pathFriendly through to collection items so pathFriendly:false
callers keep path chars raw in snapshot content
- DanglingSnapshotsCheck: materialize tracked files into HashSets once instead
of LINQ Contains over a ConcurrentBag per file (O(files*tracked) -> O(files))
- Add tests for the above; update the two VerifyChecksTests snapshots for the
.gitignore casing
SimonCropp
deleted the
Fix-correctness-and-perf-issues-in-compare,-recording,-naming-and-checks
branch
July 5, 2026 08:26
This was referenced Jul 6, 2026
Closed
Closed
Closed
Closed
This was referenced Jul 17, 2026
agocke
pushed a commit
to serdedotnet/serde
that referenced
this pull request
Jul 20, 2026
Updated [Verify](https://github.com/VerifyTests/Verify) from 31.20.0 to 31.25.0. <details> <summary>Release notes</summary> _Sourced from [Verify's releases](https://github.com/VerifyTests/Verify/releases)._ ## 31.25.0 - [x] [#1758](VerifyTests/Verify#1758) UseProjectRelative + SourceFileRelativeDirectory - [x] [#1800](VerifyTests/Verify#1800) Add mirror source structure for verified files ## 31.24.3 - [x] [#1799](VerifyTests/Verify#1799) Better line ending failure diagnostics ## 31.24.2 - [ ] [#1794](VerifyTests/Verify#1794) Normalize scrubbed-to-empty text to emptyString - [x] [#1798](VerifyTests/Verify#1798) Bump package references ## 31.24.1 - [x] [#1790](VerifyTests/Verify#1790) Only load referenced plugins ## 31.24.0 - [x] [#1789](VerifyTests/Verify#1789) Add ExcludeTargets with converter-side IsTargetExcluded check ## 31.23.0 - [x] [#1785](VerifyTests/Verify#1785) Fix chunk boundary scrubber bugs and test adapter defects - [x] [#1788](VerifyTests/Verify#1788) Add exclude targets to omit targets by extension ## 31.22.0 - [x] [#1778](VerifyTests/Verify#1778) Allow conversion splitters for text extensions - [x] [#1779](VerifyTests/Verify#1779) Fix chunk boundary scrubber bugs and test adapter defects - [x] [#1781](VerifyTests/Verify#1781) stop using MSTest metapackage - [x] [#1782](VerifyTests/Verify#1782) Migrate CI to Microsoft.Testing.Platform so all tests run - [x] [#1783](VerifyTests/Verify#1783) Guard against duplicate xunit attachment names - [x] [#1784](VerifyTests/Verify#1784) Add Kill process locking file option ## 31.21.0 - [x] [#1656](VerifyTests/Verify#1656) throw for greedy RegisterFileConverter - [x] [#1762](VerifyTests/Verify#1762) Reject carriage returns in verified files instead of normalizing - [x] [#1767](VerifyTests/Verify#1767) Fix correctness and perf issues in compare, recording, naming and checks - [x] [#1768](VerifyTests/Verify#1768) Fix VerifySettings copy constructor, temp cleanup, and stream/extensi… - [x] [#1769](VerifyTests/Verify#1769) Fix combination runner/converter, Expecto directory verification, and… - [x] [#1770](VerifyTests/Verify#1770) Fix serialization scrub/convert bugs and reduce per-value scrubbing allocations - [x] [#1771](VerifyTests/Verify#1771) Fix verifier cleanup composition, stream/xml disposal and comparison - [x] [#1772](VerifyTests/Verify#1772) Bump Argon from 0.34.0 to 0.35.0 - [x] [#1773](VerifyTests/Verify#1773) Bump DiffEngine from 19.2.0 to 19.3.0 - [x] [#1774](VerifyTests/Verify#1774) Clear synchronization context in to task() - [x] [#1775](VerifyTests/Verify#1775) Throw for greedy RegisterFileConverter<object> Commits viewable in [compare view](VerifyTests/Verify@31.20.0...31.25.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.