Fix chunk boundary scrubber bugs and test adapter defects#1785
Merged
SimonCropp merged 4 commits intoJul 9, 2026
Conversation
Scrubbers (Verify core): - UserMachineScrubber: fix IndexOutOfRangeException when a match ends exactly on a chunk boundary with a following chunk (read the trailing char via the builder indexer instead of chunkSpan[neededFromCurrent]) - UserMachineScrubber, GuidScrubber, DirectoryReplacements: roll the carryover forward across chunks so a token spanning three or more chunks (with a middle chunk shorter than the token) is no longer silently left unscrubbed - DateFormatLengthCalculator: 'K' contributes 0 to the minimum length (it can render as "", "Z" or "+11:00"), so round-trip/"o" formats now scrub the Z and offset-less forms instead of only the offset form - LinesScrubber.ReplaceLines: guard the trailing-newline trim on the rebuilt builder length, not the original string length, fixing an ArgumentOutOfRangeException when every line is replaced with null Test-framework adapters: - MSTest Verifier: only apply TestData parameters when their count matches the method parameter count (matches XunitV3; params-array DataRows no longer break parameterized snapshot naming) - MSTest Verifier_Archive: forward the dropped archiveExtension in the VerifyZip(Stream) overload - MSTest TestExecutionContext: resolve Method lazily so the method scan runs only when a verifier is built - MSTest source generator: require an attribute list in the syntax predicate so the uncached CreateSyntaxProvider transform no longer runs semantic work for every class on every keystroke - NUnit VerifyBase_Tuple: pass sourceFile so snapshots resolve to the test's path rather than the package build path - NUnit VerifyBase_Stream: use settings ?? this.settings in the Task<T> and ValueTask<T> stream overloads so instance settings are honored Add repro tests for the scrubber fixes.
SimonCropp
deleted the
Fix-chunk-boundary-scrubber-bugs-and-test-adapter-defects
branch
July 9, 2026 10:27
20 tasks
21 tasks
This was referenced Jul 11, 2026
This was referenced Jul 20, 2026
agocke
pushed a commit
to serdedotnet/serde
that referenced
this pull request
Jul 20, 2026
Updated [Verify](https://github.com/VerifyTests/Verify) from 31.20.0 to 31.25.0. <details> <summary>Release notes</summary> _Sourced from [Verify's releases](https://github.com/VerifyTests/Verify/releases)._ ## 31.25.0 - [x] [#1758](VerifyTests/Verify#1758) UseProjectRelative + SourceFileRelativeDirectory - [x] [#1800](VerifyTests/Verify#1800) Add mirror source structure for verified files ## 31.24.3 - [x] [#1799](VerifyTests/Verify#1799) Better line ending failure diagnostics ## 31.24.2 - [ ] [#1794](VerifyTests/Verify#1794) Normalize scrubbed-to-empty text to emptyString - [x] [#1798](VerifyTests/Verify#1798) Bump package references ## 31.24.1 - [x] [#1790](VerifyTests/Verify#1790) Only load referenced plugins ## 31.24.0 - [x] [#1789](VerifyTests/Verify#1789) Add ExcludeTargets with converter-side IsTargetExcluded check ## 31.23.0 - [x] [#1785](VerifyTests/Verify#1785) Fix chunk boundary scrubber bugs and test adapter defects - [x] [#1788](VerifyTests/Verify#1788) Add exclude targets to omit targets by extension ## 31.22.0 - [x] [#1778](VerifyTests/Verify#1778) Allow conversion splitters for text extensions - [x] [#1779](VerifyTests/Verify#1779) Fix chunk boundary scrubber bugs and test adapter defects - [x] [#1781](VerifyTests/Verify#1781) stop using MSTest metapackage - [x] [#1782](VerifyTests/Verify#1782) Migrate CI to Microsoft.Testing.Platform so all tests run - [x] [#1783](VerifyTests/Verify#1783) Guard against duplicate xunit attachment names - [x] [#1784](VerifyTests/Verify#1784) Add Kill process locking file option ## 31.21.0 - [x] [#1656](VerifyTests/Verify#1656) throw for greedy RegisterFileConverter - [x] [#1762](VerifyTests/Verify#1762) Reject carriage returns in verified files instead of normalizing - [x] [#1767](VerifyTests/Verify#1767) Fix correctness and perf issues in compare, recording, naming and checks - [x] [#1768](VerifyTests/Verify#1768) Fix VerifySettings copy constructor, temp cleanup, and stream/extensi… - [x] [#1769](VerifyTests/Verify#1769) Fix combination runner/converter, Expecto directory verification, and… - [x] [#1770](VerifyTests/Verify#1770) Fix serialization scrub/convert bugs and reduce per-value scrubbing allocations - [x] [#1771](VerifyTests/Verify#1771) Fix verifier cleanup composition, stream/xml disposal and comparison - [x] [#1772](VerifyTests/Verify#1772) Bump Argon from 0.34.0 to 0.35.0 - [x] [#1773](VerifyTests/Verify#1773) Bump DiffEngine from 19.2.0 to 19.3.0 - [x] [#1774](VerifyTests/Verify#1774) Clear synchronization context in to task() - [x] [#1775](VerifyTests/Verify#1775) Throw for greedy RegisterFileConverter<object> Commits viewable in [compare view](VerifyTests/Verify@31.20.0...31.25.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Jul 20, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.