atenet: drop redundant deployment mode - #635
Open
John Howard (howardjohn) wants to merge 1 commit into
Open
Conversation
This is intended to be essentially a dead code cleanup, not a controversial change. There were two ways to deploy the same proxy component; I assume no one is customizing the deployment mechanic, and this follows how other components work (just deployed with YAML). This simplifies the setup so we only need to maintain one path. The default option is retained so there is no behavioral changes.
John Howard (howardjohn)
force-pushed
the
net/drop-managed-envoy
branch
from
July 30, 2026 15:00
61ba3a7 to
1620aa1
Compare
NekoPunch (orangeCatDeveloper)
added a commit
to orangeCatDeveloper/substrate
that referenced
this pull request
Aug 2, 2026
Both were single-replica SPOFs: every deploy or node drain took the data plane down. Surge-only rollout, Envoy readiness gating, preStop drain, soft hostname spread, and PDBs make disruptions non-events. The managed-Envoy path (envoyrunner.go) stays single-replica; agent-substrate#635 removes that mode.
NekoPunch (orangeCatDeveloper)
added a commit
to orangeCatDeveloper/substrate
that referenced
this pull request
Aug 4, 2026
Both were single-replica SPOFs: every deploy or node drain took the data plane down. Surge-only rollout, Envoy readiness gating, preStop drain, soft hostname spread, and PDBs make disruptions non-events. The managed-Envoy path (envoyrunner.go) stays single-replica; agent-substrate#635 removes that mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended to be essentially a dead code cleanup, not a controversial change. There were two ways to deploy the same proxy component; I assume no one is customizing the deployment mechanic, and this follows how other components work (just deployed with YAML).
This simplifies the setup so we only need to maintain one path. The default option is retained so there is no behavioral changes.