atenet: two replicas + PDBs for router and dns - #704
Open
NekoPunch (orangeCatDeveloper) wants to merge 1 commit into
Open
atenet: two replicas + PDBs for router and dns#704NekoPunch (orangeCatDeveloper) wants to merge 1 commit into
NekoPunch (orangeCatDeveloper) wants to merge 1 commit into
Conversation
Both were single-replica SPOFs: every deploy or node drain took the data plane down. Surge-only rollout, Envoy readiness gating, preStop drain, soft hostname spread, and PDBs make disruptions non-events. The managed-Envoy path (envoyrunner.go) stays single-replica; agent-substrate#635 removes that mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The atenet-router and dns Deployments are single-replica SPOFs: every deploy, node drain, or eviction takes the whole data plane down (measured ~5.5 s of hard connection failures per router pod kill; 6,880 dial errors during one GKE node-pool event — see #645). This bumps both to 2 replicas with a surge-only rollout (
maxUnavailable: 0), an Envoy readiness probe (admin/ready, which passes only after the initial xDS load from the router container), preStop drain sleeps on all three containers, soft hostname spread, and PodDisruptionBudgets.preStop uses the native K8s ≥1.30
sleepaction because the ko and coredns images are distroless (nosleepbinary). The router container needs its own drain: it hosts ext_proc, and if it dies while the draining Envoy still receives traffic, requests fail with 500.The multi-replica xDS question flagged in #645 is resolved by #699 (restart- and replica-unique version epochs); in standalone sidecar mode each Envoy only talks to its pod-local router, so replicas never share an xDS stream.
Out of scope: the managed-Envoy path (
envoyrunner.go) stays single-replica — #635 removes that mode entirely.Fixes #645
Test plan
On a kind cluster, with a 5 req/s in-cluster probe against a running actor: