Skip to content

fix: update threads chart tag - #214

Merged
vitramir merged 8 commits into
mainfrom
noa/issue-9
Apr 2, 2026
Merged

fix: update threads chart tag#214
vitramir merged 8 commits into
mainfrom
noa/issue-9

Conversation

@casey-brooks

Copy link
Copy Markdown
Contributor

Summary

  • resolve threads image tag from chart version directly
  • clear threads image tag override and bump chart version

Testing

  • ./apply.sh -y

Issue

@casey-brooks
casey-brooks requested a review from a team as a code owner April 2, 2026 10:02
@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • ./apply.sh -y

noa-lucent
noa-lucent previously approved these changes Apr 2, 2026

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Changes are minimal and correct:

  • resolved_threads_image_tag now resolves directly to var.threads_chart_version (without v prefix), consistent with the new multi-arch release workflow in agynio/threads that tags images as 0.2.0 (not v0.2.0). This matches the pattern already used by gateway, k8s_runner, and chat.
  • threads_image_tag override cleared to "" so the chart version drives the image tag.
  • threads_chart_version bumped to 0.2.0.

Minor note: the PR body references #9 which resolves to #9 (ArgoCD upgrade), not the threads issue. The intended reference is likely agynio/threads#9. Not blocking.

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • ./apply.sh -y

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • ./apply.sh -y
  • terraform fmt -check -recursive

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • ./apply.sh -y (passed: 1, failed: 0, skipped: 0)
  • terraform fmt -check -recursive (lint: no errors)

2 similar comments
@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • ./apply.sh -y (passed: 1, failed: 0, skipped: 0)
  • terraform fmt -check -recursive (lint: no errors)

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • ./apply.sh -y (passed: 1, failed: 0, skipped: 0)
  • terraform fmt -check -recursive (lint: no errors)

@rowan-stein

Copy link
Copy Markdown
Collaborator

Requesting review. This PR updates the threads service deployment to use the new multi-arch release (v0.3.1):

  • Removes format("v%s", ...) from threads image tag resolution — aligns with the semver tag convention from the new release workflow
  • Bumps threads_chart_version to 0.3.1
  • Clears the threads_image_tag override (derives from chart version)
  • Converts Helm values from old custom chart format to service-base chart format (env list, service.ports)

CI (full-apply with k3d cluster) passes — threads pod is healthy.

noa-lucent
noa-lucent previously approved these changes Apr 2, 2026

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All changes are correct and well-scoped:

  • Image tag convention (main.tf:6): Drops format("v%s", ...) from resolved_threads_image_tag, now resolving directly to var.threads_chart_version. This aligns with the threads release workflow (PR agynio/threads#10) which tags images as 0.3.1 not v0.3.1 — consistent with gateway, k8s_runner, and chat.

  • Helm values migration (main.tf:863-898): Converts from the old custom chart format (service.port, database.url, notifications.address) to the service-base chart format (service.ports list, env list). The structure matches the threads chart v0.3.1 values.yaml exactly. Also adds IDENTITY_ADDRESS and AUTHORIZATION_ADDRESS env vars required by the v0.2.0+ feature code.

  • Version bump (variables.tf): threads_chart_version0.3.1, threads_image_tag override cleared to "" so chart version drives the tag.

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • ./apply.sh -y (passed: 1, failed: 0, skipped: 0)
  • terraform fmt -check -recursive (lint: no errors)

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • ./apply.sh -y (passed: 1, failed: 0, skipped: 0)
  • terraform fmt -check -recursive (lint: no errors)

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • ./apply.sh -y (passed: 1, failed: 0, skipped: 0)
  • terraform fmt -check -recursive (lint: no errors)

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • ./apply.sh -y (passed: 1, failed: 0, skipped: 0)
  • terraform fmt -check -recursive (lint: no errors)

@vitramir
vitramir merged commit d30951a into main Apr 2, 2026
1 of 2 checks passed
casey-brooks added a commit that referenced this pull request Apr 27, 2026
* fix: update threads image tag

* fix: bump threads chart version

* fix: bump threads chart version

* fix: align threads values with chart

* fix: trim threads env defaults

* fix: drop threads service envs

* chore: bump threads chart

* fix: keep threads env defaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants