fix: update threads chart tag - #214
Conversation
Test & Lint Summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
LGTM. Changes are minimal and correct:
resolved_threads_image_tagnow resolves directly tovar.threads_chart_version(withoutvprefix), consistent with the new multi-arch release workflow in agynio/threads that tags images as0.2.0(notv0.2.0). This matches the pattern already used by gateway, k8s_runner, and chat.threads_image_tagoverride cleared to""so the chart version drives the image tag.threads_chart_versionbumped to0.2.0.
Minor note: the PR body references #9 which resolves to #9 (ArgoCD upgrade), not the threads issue. The intended reference is likely agynio/threads#9. Not blocking.
9f1c607 to
da996e8
Compare
Test & Lint Summary
|
Test & Lint Summary
|
Test & Lint Summary
|
2 similar comments
Test & Lint Summary
|
Test & Lint Summary
|
|
Requesting review. This PR updates the threads service deployment to use the new multi-arch release (v0.3.1):
CI (full-apply with k3d cluster) passes — threads pod is healthy. |
noa-lucent
left a comment
There was a problem hiding this comment.
LGTM. All changes are correct and well-scoped:
-
Image tag convention (
main.tf:6): Dropsformat("v%s", ...)fromresolved_threads_image_tag, now resolving directly tovar.threads_chart_version. This aligns with the threads release workflow (PR agynio/threads#10) which tags images as0.3.1notv0.3.1— consistent with gateway, k8s_runner, and chat. -
Helm values migration (
main.tf:863-898): Converts from the old custom chart format (service.port,database.url,notifications.address) to the service-base chart format (service.portslist,envlist). The structure matches the threads chart v0.3.1values.yamlexactly. Also addsIDENTITY_ADDRESSandAUTHORIZATION_ADDRESSenv vars required by the v0.2.0+ feature code. -
Version bump (
variables.tf):threads_chart_version→0.3.1,threads_image_tagoverride cleared to""so chart version drives the tag.
Test & Lint Summary
|
619ee2b to
53ce283
Compare
Test & Lint Summary
|
Test & Lint Summary
|
Test & Lint Summary
|
* fix: update threads image tag * fix: bump threads chart version * fix: bump threads chart version * fix: align threads values with chart * fix: trim threads env defaults * fix: drop threads service envs * chore: bump threads chart * fix: keep threads env defaults
Summary
Testing
Issue