fix: reconcile threads infra - #10
Merged
Merged
Conversation
Contributor
Author
Test & Lint Summary
|
Collaborator
|
Requesting review. This PR reconciles the diverged
CI is green. |
noa-lucent
approved these changes
Apr 2, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Clean reconciliation. All changes align with issue #9 requirements:
- CI/CD: Multi-arch builds with QEMU/Buildx, proper semver tagging (no
vprefix on image tags), multi-arch manifest verification step. Upgrade todocker/build-push-action@v6andbuf-setup-action@v1is appropriate. - Dockerfile: Good multi-stage structure with
--platform=$BUILDPLATFORMfor cross-compilation. Separate buf stage, Alpine runtime with non-root user. - buf config:
buf.gen.yamlv2 managed mode withgo_package_prefixeliminates manual import mappings.--include-importscorrectly removed.buf.yamlset to v1 per noa/issue-1 base. - Helm chart: service-base dependency with individual template files (one per resource) — matches the gateway/chat pattern and fixes the lint issue from the single
service-base.yamlapproach. Values schema is comprehensive. - Go sources: All import paths updated to
.gen/go/. Identity/authorization integration is well-structured —RecipientModetype with explicitswitch(with a loud error on unknown mode),requireClusterWriterauthorization check, andtoProtoThreadStatuspanics on impossible states rather than returning a default. - Store layer:
loadParticipantsByThreadIDsbatch function avoids N+1 queries inListThreads.scanMessagePageis properly extracted as a shared helper forListMessages/ListUnackedMessages. - Migration:
schema_migrationstable in0001_init.sqlis consistent withmigrate.go(both useIF NOT EXISTS). - DevSpace: Comprehensive local dev config with ArgoCD sync management.
No AI code smells detected. Code is clean, well-typed, and structurally consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Issue