fix: resolve CI lint failures (fmt, lockfile, markdownlint)#13
Merged
Conversation
Add spaces around table separator pipes for compact style compliance. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Feb 17, 2026
akiojin
pushed a commit
that referenced
this pull request
Mar 3, 2026
fix: resolve CI lint failures (fmt, lockfile, markdownlint)
arghhhhh
added a commit
to arghhhhh/unity-cli
that referenced
this pull request
Jun 23, 2026
…refs Pass-1 breadth proof for Preferences (akiojin#13). Reuses the existing vfx_settings tool with a new `scope` param (default "project"; "preferences" routes to EditorPrefs via UnityEditor.VFX.VFXViewPreference). - VfxGraphHandler: VFXViewPreferenceType + a canonical 11-entry preference table (propName, keyConstName, type). GetVfxPreferences reflects each public static property — instancingEnabled, displayExperimentalOperator, multithreadUpdateEnabled, forceEditionCompilation, advancedLogs, cameraBuffersFallback (enum→name), authoringPrewarm{Step,Max}, ... - SetVfxPreference resolves the key constant by reflection, calls the matching EditorPrefs.SetBool/SetInt/SetFloat, invalidates the cache via VFXViewPreference.SetDirty(), then re-reads through the canonical property to confirm the round-trip. Result echoes the resolved editorPrefsKey (e.g. "VFX.InstancingEnabled"). - Catalog: schema widened with `scope` string; description updated to cover both scopes. Tool-level mutating unchanged (parity count stays 134). - Tests (3 new, total 48 EditMode, 0 skipped): * contract: unknown pref name returns a descriptive error listing the 11 known names; * behavioral get: properties block surfaces instancingEnabled, displayExperimentalOperator, multithreadUpdateEnabled; * behavioral set: instancingEnabled flips and round-trips via re-read, editorPrefsKey resolves to the package's "VFX.InstancingEnabled" constant, restored in finally. - Skill + docs: split scope:project / scope:preferences examples and call out the Instancing master gate (gate akiojin#1 of akiojin#16's 3-gate reconciliation). Verified live via raw: get scope:preferences surfaces all 11 prefs; set instancingEnabled=false re-reads as false; set authoringPrewarmStepCountPerSeconds=40 (int) round-trips; restored. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
arghhhhh
added a commit
to arghhhhh/unity-cli
that referenced
this pull request
Jun 23, 2026
Closes the Preferences checklist. allowShaderExternalization is the one VFX
editor pref with no public getter property on VFXViewPreference — only a key
constant ("VFX.allowShaderExternalization") and a private field — so the existing
property-reflection read path skipped it.
Refactored ReadPrefProperty into ReadPref(entry): prefers the canonical public
static property (which reflects VFXViewPreference's cache) and falls back to a
direct EditorPrefs.GetBool/GetInt/GetFloat by key+type when no property exists.
Added the pref to the canonical table; the set path already wrote via EditorPrefs
by key, so writes worked — only the read-back needed the fallback.
Verified live + EditMode: get now lists allowShaderExternalization (12 prefs),
set true round-trips via re-read echoing editorPrefsKey "VFX.allowShaderExternalization",
restores cleanly. 5-layer: handler + ReadPref refactor; skill + docs/tools.md
(no catalog change — vfx_settings schema already covers scope/setting/value);
1 EditMode round-trip test (85 passed / 0 failed / 0 skipped).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
arghhhhh
added a commit
to arghhhhh/unity-cli
that referenced
this pull request
Jun 25, 2026
…refs Pass-1 breadth proof for Preferences (akiojin#13). Reuses the existing vfx_settings tool with a new `scope` param (default "project"; "preferences" routes to EditorPrefs via UnityEditor.VFX.VFXViewPreference). - VfxGraphHandler: VFXViewPreferenceType + a canonical 11-entry preference table (propName, keyConstName, type). GetVfxPreferences reflects each public static property — instancingEnabled, displayExperimentalOperator, multithreadUpdateEnabled, forceEditionCompilation, advancedLogs, cameraBuffersFallback (enum→name), authoringPrewarm{Step,Max}, ... - SetVfxPreference resolves the key constant by reflection, calls the matching EditorPrefs.SetBool/SetInt/SetFloat, invalidates the cache via VFXViewPreference.SetDirty(), then re-reads through the canonical property to confirm the round-trip. Result echoes the resolved editorPrefsKey (e.g. "VFX.InstancingEnabled"). - Catalog: schema widened with `scope` string; description updated to cover both scopes. Tool-level mutating unchanged (parity count stays 134). - Tests (3 new, total 48 EditMode, 0 skipped): * contract: unknown pref name returns a descriptive error listing the 11 known names; * behavioral get: properties block surfaces instancingEnabled, displayExperimentalOperator, multithreadUpdateEnabled; * behavioral set: instancingEnabled flips and round-trips via re-read, editorPrefsKey resolves to the package's "VFX.InstancingEnabled" constant, restored in finally. - Skill + docs: split scope:project / scope:preferences examples and call out the Instancing master gate (gate akiojin#1 of akiojin#16's 3-gate reconciliation). Verified live via raw: get scope:preferences surfaces all 11 prefs; set instancingEnabled=false re-reads as false; set authoringPrewarmStepCountPerSeconds=40 (int) round-trips; restored. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
arghhhhh
added a commit
to arghhhhh/unity-cli
that referenced
this pull request
Jun 25, 2026
Closes the Preferences checklist. allowShaderExternalization is the one VFX
editor pref with no public getter property on VFXViewPreference — only a key
constant ("VFX.allowShaderExternalization") and a private field — so the existing
property-reflection read path skipped it.
Refactored ReadPrefProperty into ReadPref(entry): prefers the canonical public
static property (which reflects VFXViewPreference's cache) and falls back to a
direct EditorPrefs.GetBool/GetInt/GetFloat by key+type when no property exists.
Added the pref to the canonical table; the set path already wrote via EditorPrefs
by key, so writes worked — only the read-back needed the fallback.
Verified live + EditMode: get now lists allowShaderExternalization (12 prefs),
set true round-trips via re-read echoing editorPrefsKey "VFX.allowShaderExternalization",
restores cleanly. 5-layer: handler + ReadPref refactor; skill + docs/tools.md
(no catalog change — vfx_settings schema already covers scope/setting/value);
1 EditMode round-trip test (85 passed / 0 failed / 0 skipped).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes for CI failures after PR #12 was auto-merged:
cargo fmtformatting applied tosrc/config.rspnpm-lock.yamlregenerated to matchpackage.jsonspecs/specs.mdupdated viaupdate-specs-readme.shREADME.md,RELEASE.md,docs/development.mdTest plan
cargo test— all 34 tests passnpx markdownlint-cli README.md RELEASE.md docs/development.md— no errorscargo fmt --all -- --check— no diff🤖 Generated with Claude Code