Skip to content

test(sdk): use a deployment id the schema pattern accepts - #436

Closed
ItamarZand88 wants to merge 1 commit into
mainfrom
fix/sdk-reconcile-test-deployment-id
Closed

test(sdk): use a deployment id the schema pattern accepts#436
ItamarZand88 wants to merge 1 commit into
mainfrom
fix/sdk-reconcile-test-deployment-id

Conversation

@ItamarZand88

Copy link
Copy Markdown
Contributor

Summary

The reconcile round-trip test added in #432 uses a 24-character deployment id, and the platform spec pins deployment ids to dep_ + 28 characters, so the request never deserializes and alien-platform-api's tests fail on main. This gives the test an id the schema accepts.

When the test runs:

  1. It builds a reconcile request with a deployment id and a runtime-metadata state.
  2. The generated request type validates the id against the spec pattern before anything else — with 24 characters that step fails and the test never reaches its assertions.
  3. With a 28-character id it deserializes and the round-trip assertions run.

This changes the test's fixture id to one the schema pattern accepts.

How I tested

  • cargo test -p alien-platform-api reconcile_state_preserves — fails on main with doesn't match pattern "dep_[0-9a-z]{28}$", passes with this change.

The reconcile round-trip test used a 24-character id, and the platform
spec pins deployment ids to 28, so the request never deserialized and
the test failed on main.
@greptile-apps

greptile-apps Bot commented Aug 17, 2026

Copy link
Copy Markdown

Greptile Summary

The PR corrects the Rust SDK reconcile round-trip test fixture so its deployment ID conforms to the platform schema.

  • Extends the fixture’s deployment ID suffix from 24 to 28 lowercase alphanumeric characters.
  • Allows request deserialization to proceed to the existing runtime-metadata round-trip assertions.

Confidence Score: 5/5

The PR appears safe to merge because the updated test fixture matches the deployment ID schema and does not alter production behavior.

The changed literal satisfies the exact schema pattern, and the test’s subsequent assertions do not impose any conflicting deployment ID expectation.

Important Files Changed

Filename Overview
client-sdks/platform/rust/src/lib.rs Updates a test-only deployment ID to match the schema’s required dep_ plus 28-character pattern; no actionable issue found.

Reviews (1): Last reviewed commit: "test(sdk): use a deployment id the schem..." | Re-trigger Greptile

@ItamarZand88
ItamarZand88 deleted the fix/sdk-reconcile-test-deployment-id branch August 17, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant