test(sdk): use a deployment id the schema pattern accepts - #436
Closed
ItamarZand88 wants to merge 1 commit into
Closed
test(sdk): use a deployment id the schema pattern accepts#436ItamarZand88 wants to merge 1 commit into
ItamarZand88 wants to merge 1 commit into
Conversation
The reconcile round-trip test used a 24-character id, and the platform spec pins deployment ids to 28, so the request never deserialized and the test failed on main.
Greptile SummaryThe PR corrects the Rust SDK reconcile round-trip test fixture so its deployment ID conforms to the platform schema.
Confidence Score: 5/5The PR appears safe to merge because the updated test fixture matches the deployment ID schema and does not alter production behavior. The changed literal satisfies the exact schema pattern, and the test’s subsequent assertions do not impose any conflicting deployment ID expectation.
|
| Filename | Overview |
|---|---|
| client-sdks/platform/rust/src/lib.rs | Updates a test-only deployment ID to match the schema’s required dep_ plus 28-character pattern; no actionable issue found. |
Reviews (1): Last reviewed commit: "test(sdk): use a deployment id the schem..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The reconcile round-trip test added in #432 uses a 24-character deployment id, and the platform spec pins deployment ids to
dep_+ 28 characters, so the request never deserializes andalien-platform-api's tests fail onmain. This gives the test an id the schema accepts.When the test runs:
This changes the test's fixture id to one the schema pattern accepts.
How I tested
cargo test -p alien-platform-api reconcile_state_preserves— fails onmainwithdoesn't match pattern "dep_[0-9a-z]{28}$", passes with this change.