Skip to content

test(sdk): use stable reconcile request type - #432

Merged
alongubkin merged 1 commit into
mainfrom
alon/alien-525-fix-reconcile-sdk-test
Aug 17, 2026
Merged

test(sdk): use stable reconcile request type#432
alongubkin merged 1 commit into
mainfrom
alon/alien-525-fix-reconcile-sdk-test

Conversation

@alongubkin

Copy link
Copy Markdown
Member

Summary

  • deserialize the generated SyncReconcileRequest in the SDK round-trip test
  • avoid referencing the removed inline SyncReconcileRequestState type after model deduplication

Validation

  • this is the focused fix from local commit b2b40f402 for the E0425 release-PR failure
  • git diff --check

Linear: ALIEN-525

@alongubkin

Copy link
Copy Markdown
Member Author

Admin-merging to unblock v3.3.14 qualification. This is the focused stale generated-type test fix already validated in local commit b2b40f4; release PR #431 currently fails because it does not include it.

@alongubkin
alongubkin merged commit a97da2a into main Aug 17, 2026
8 checks passed
@alongubkin
alongubkin deleted the alon/alien-525-fix-reconcile-sdk-test branch August 17, 2026 07:45
@greptile-apps

greptile-apps Bot commented Aug 17, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates the Rust platform SDK round-trip test to deserialize through the stable generated SyncReconcileRequest type after model deduplication.

  • Wraps the existing deployment-state fixture with a valid deployment ID.
  • Serializes the generated request’s state and retains the runtime-update metadata assertions.

Confidence Score: 5/5

The PR appears safe to merge because the focused test-only change supplies all required request-level fields and preserves the existing metadata assertions.

The change replaces a removed inline generated type reference with deserialization through the stable request model, and no concrete build, serialization, or runtime failure remains established.

Important Files Changed

Filename Overview
client-sdks/platform/rust/src/lib.rs Updates a test to exercise the stable generated reconcile-request type without changing production behavior; no actionable defect was established.

Reviews (1): Last reviewed commit: "test(sdk): use stable reconcile request ..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant